Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Contributions Managers now show specific titles (like "Mode Manager", "Tool Manager", etc.) in the user's preferred language #2777
There was no contributions field in the PDE.properties, which caused a MissingResourceException to be thrown each time a Tool/Mode/Library Manager was started. Further, we may need the title String, since each of the managers will need their entire title specified (since concatenating the type.getTitle() with " Manager" would no longer work, since, for example, in French, it would be written the other way around).
Oh my. Sorry. I didn't notice. I'll close this.
Would adding fields for the individual contribution managers be helpful, so that the title bars read "Tool Manager", "Mode Manager", etc.? If so, I'll either submit a PR onto the branch which you've filed the PR with, or I'll wait till your PR gets accepted.
I rather like the
One other thing, regarding @joelmoniz's comment. Many language strings in the codebase attempt to interpolate the contribution type inside. This can be a problem for some languages if the words are of different grammatical gender. For example, in english you can talk about the mode or the tool, but in spanish you need to use el modo and la herramienta.
This is why you will find that the spanish translation usually talks about la contribución and ignores the interpolation argument.