New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve how the Contributions Manager handles no internet connection (or an unreliable one) #2800

Merged
merged 3 commits into from Aug 19, 2014

Conversation

Projects
None yet
2 participants
@joelmoniz
Copy link
Member

joelmoniz commented Aug 16, 2014

This resolves #2426.

2 main types of errors have been identified:

  1. UnknownHostException, which happens when there is no internet connection
  2. SocketTimeoutException, which happens for an unreliable connection, or a connection which gets cut in between a download

The following error messages have been used for the contributions.txt:

  • SocketTimeout: Connection timed out while downloading the contribution list.
  • UnknownHost: Could not download the list of available contributions.

and for the contribution itself:

  • SocketTimeout: Connection timed out while downloading <contrib_name>.
  • UnknownHost: Error during download and install of <contrib_name>

In case the contributions.txt file doesn't download, a Retry button has been added, and all install and update buttons will be disabled.

benfry added a commit that referenced this pull request Aug 19, 2014

Merge pull request #2800 from joelmoniz/improveNoInternet
Improve how the Contributions Manager handles no internet connection (or an unreliable one)

@benfry benfry merged commit 81c6edf into processing:master Aug 19, 2014

@joelmoniz joelmoniz deleted the joelmoniz:improveNoInternet branch Dec 14, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment