New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix building on Windows (#3062) #3066

Merged
merged 1 commit into from Jan 28, 2015

Conversation

Projects
None yet
2 participants
@JakubValtar
Contributor

JakubValtar commented Jan 28, 2015

Fixes #3062

I checked all launch4j files in the repository against their latest versions for win (3.6.1), mac (3.6) and linux (3.6). The only file which was not up to date was launch4j.jar. I replaced it with the latest version (jars from win, mac and linux distributions are binary equal, so nothing should break).

Tested on Windows, please try ant clean & ant build on mac and linux.

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Jan 28, 2015

Member

What jar is this? An old version or was the .jar itself not updated properly for 3.6?

Member

benfry commented Jan 28, 2015

What jar is this? An old version or was the .jar itself not updated properly for 3.6?

@JakubValtar

This comment has been minimized.

Show comment
Hide comment
@JakubValtar

JakubValtar Jan 28, 2015

Contributor

It seems that the jar was not updated properly (it was different from the one from 3.6 release). I replaced it with the jar from 3.6. All launch4j files should be 3.6 now.

Contributor

JakubValtar commented Jan 28, 2015

It seems that the jar was not updated properly (it was different from the one from 3.6 release). I replaced it with the jar from 3.6. All launch4j files should be 3.6 now.

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Jan 28, 2015

Member

Yup, dumb mistake; just didn't update it (after carefully dealing with all those other binaries...)

Member

benfry commented Jan 28, 2015

Yup, dumb mistake; just didn't update it (after carefully dealing with all those other binaries...)

benfry added a commit that referenced this pull request Jan 28, 2015

@benfry benfry merged commit ac6f4e1 into processing:master Jan 28, 2015

@JakubValtar JakubValtar deleted the JakubValtar:bugfix-win-build-launch4j branch Jan 28, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment