New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent memory leak of Client by unregistering parent dispose method #3088

Merged
merged 2 commits into from Apr 1, 2015

Conversation

Projects
None yet
2 participants
@kfeuz
Contributor

kfeuz commented Feb 5, 2015

This addresses issue #1400 dealing with a memory leak in the processing.net.Client which occurs when the parent "dispose" method is not unregistered if the client is stopped. Rather than trying to track the state of several different variables, I've just declared an explicit boolean variable to track whether or not the dispose method needs to be unregistered. Now when spawning and closing Clients the memory usage stays consistent.

benfry added a commit that referenced this pull request Apr 1, 2015

Merge pull request #3088 from kfeuz/client_memory_leak
Prevent memory leak of Client by unregistering parent dispose method

@benfry benfry merged commit 5a6c3dc into processing:master Apr 1, 2015

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Apr 1, 2015

Member

Thanks for the fix.

Member

benfry commented Apr 1, 2015

Thanks for the fix.

benfry added a commit that referenced this pull request Apr 1, 2015

@kfeuz kfeuz deleted the kfeuz:client_memory_leak branch Feb 17, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment