New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server check for dead clients while checking for available messages #3097

Merged
merged 1 commit into from Feb 21, 2015

Conversation

Projects
None yet
2 participants
@kfeuz
Contributor

kfeuz commented Feb 6, 2015

As discussed in issue #3089 the processing.net.Server only cleans up dead clients when trying to write to them. This patch has the server also check for dead clients while it is looking for available data to read. The check is done in such a way so that a client that has died with unread data can still be read. Additionally, the order of the clients should remain consistent and no client should be skipped. I have included comments explaining the code so that in the future the non-obvious statements can be easily understood.

benfry added a commit that referenced this pull request Feb 21, 2015

Merge pull request #3097 from kfeuz/server_memory_leak
Server check for dead clients while checking for available messages

@benfry benfry merged commit 78c5d05 into processing:master Feb 21, 2015

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Feb 21, 2015

Member

Thanks for looking into it.

Member

benfry commented Feb 21, 2015

Thanks for looking into it.

@kfeuz kfeuz deleted the kfeuz:server_memory_leak branch Feb 17, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment