New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor examples manager window: Fixes #3133 #3177

Merged
merged 1 commit into from Apr 7, 2015

Conversation

Projects
None yet
3 participants
@Plastix
Contributor

Plastix commented Apr 5, 2015

This reorganizes the examples manager tree and changes the Add Examples label into a button. Also includes misc refactoring code cleanliness and readability.

screen shot 2015-04-04 at 8 31 57 pm

@benfry

View changes

Show outdated Hide outdated app/src/processing/app/Mode.java
@@ -565,77 +565,6 @@ public void actionPerformed(ActionEvent e) {
}
}

This comment has been minimized.

@benfry

benfry Apr 7, 2015

Member

Please never remove code that's been commented out.

@benfry

benfry Apr 7, 2015

Member

Please never remove code that's been commented out.

This comment has been minimized.

@Plastix

Plastix Apr 7, 2015

Contributor

My bad, I thought I was just cleaning up the file. Commented out code can be very dangerous because when code changes the commented out code may not work anymore.

I've noticed that a lot of PDE code has lots of random code commented out.

@Plastix

Plastix Apr 7, 2015

Contributor

My bad, I thought I was just cleaning up the file. Commented out code can be very dangerous because when code changes the commented out code may not work anymore.

I've noticed that a lot of PDE code has lots of random code commented out.

This comment has been minimized.

@federicobond

federicobond Apr 7, 2015

Contributor

I fail to see the point of keeping so much commented out code in the codebase. It is pretty easy nowadays to find deleted code with version control systems. It's a bad practice in almost every code style guide.

If there is a reason, I think it should be documented so that new contributors don't waste time cleaning up commented code.

@federicobond

federicobond Apr 7, 2015

Contributor

I fail to see the point of keeping so much commented out code in the codebase. It is pretty easy nowadays to find deleted code with version control systems. It's a bad practice in almost every code style guide.

If there is a reason, I think it should be documented so that new contributors don't waste time cleaning up commented code.

This comment has been minimized.

This comment has been minimized.

@Plastix

Plastix Apr 7, 2015

Contributor

Ok will update my commit.

-Aidan Pieper

On Tue, Apr 7, 2015 at 2:36 PM, Ben Fry notifications@github.com wrote:

In app/src/processing/app/Mode.java
#3177 (comment):

@@ -565,77 +565,6 @@ public void actionPerformed(ActionEvent e) {
}
}

See the section on comments at the end:
https://github.com/processing/processing/wiki/Style-Guidelines


Reply to this email directly or view it on GitHub
https://github.com/processing/processing/pull/3177/files#r27907007.

@Plastix

Plastix Apr 7, 2015

Contributor

Ok will update my commit.

-Aidan Pieper

On Tue, Apr 7, 2015 at 2:36 PM, Ben Fry notifications@github.com wrote:

In app/src/processing/app/Mode.java
#3177 (comment):

@@ -565,77 +565,6 @@ public void actionPerformed(ActionEvent e) {
}
}

See the section on comments at the end:
https://github.com/processing/processing/wiki/Style-Guidelines


Reply to this email directly or view it on GitHub
https://github.com/processing/processing/pull/3177/files#r27907007.

@Plastix

This comment has been minimized.

Show comment
Hide comment
@Plastix

Plastix Apr 7, 2015

Contributor

@benfry Updated my commit to keep most of the commented code out.

Contributor

Plastix commented Apr 7, 2015

@benfry Updated my commit to keep most of the commented code out.

benfry added a commit that referenced this pull request Apr 7, 2015

Merge pull request #3177 from Plastix/examples-refactor
Refactor examples manager window: Fixes #3133

@benfry benfry merged commit 89e3916 into processing:master Apr 7, 2015

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Apr 7, 2015

Member

Thanks, appreciate the help.

Member

benfry commented Apr 7, 2015

Thanks, appreciate the help.

@Plastix Plastix deleted the Plastix:examples-refactor branch Apr 8, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment