New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential Tab menu fix #3236

Merged
merged 1 commit into from May 10, 2015

Conversation

Projects
None yet
2 participants
@pvrs12
Contributor

pvrs12 commented May 2, 2015

This is a possible fix for #1968 and other duplicates of this issue. It causes the tab menu to lock to the right of the window when there are too many tabs to display and it doesn't render tabs which would interfere with the menu. Resulting in something that looks like this if there are too many tabs to render.
Too many tabs
The only potential issue I see is that there is no indication that more tabs are hidden off screen. It might make sense to add another 'tab' which indicates more tabs are hidden (an ellipses or something).

Hope this fixes this issue

Allowed menu to 'stick' to the right when too many tabs exist. Tabs t…
…hat cannot be displayed are automatically hidden. Removed old code which attempted to reduce tab size by hiding the text
@pvrs12

This comment has been minimized.

Show comment
Hide comment
@pvrs12

pvrs12 May 10, 2015

Contributor

Just wanted to bump this

Contributor

pvrs12 commented May 10, 2015

Just wanted to bump this

benfry added a commit that referenced this pull request May 10, 2015

@benfry benfry merged commit 8a2b982 into processing:master May 10, 2015

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry May 10, 2015

Member

Please don't bump. I either have the time to evaluate the fix or I don't.

Member

benfry commented May 10, 2015

Please don't bump. I either have the time to evaluate the fix or I don't.

@pvrs12 pvrs12 deleted the pvrs12:tab-fix branch May 18, 2015

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry May 19, 2015

Member

Ugh, just found this. Please don't remove working code because you don't find it convenient or to your liking. This makes a mess for me to have to come back and sort it out. I wouldn't have accepted this patch had I noticed this before.

Ugh, just found this. Please don't remove working code because you don't find it convenient or to your liking. This makes a mess for me to have to come back and sort it out. I wouldn't have accepted this patch had I noticed this before.

This comment has been minimized.

Show comment
Hide comment
@pvrs12

pvrs12 May 19, 2015

Contributor

I'm sorry about that, won't happen again. What would the accepted protocol be for eventually removing old code? A separate issue? I can file a PR which puts back in the old code if you would like

Contributor

pvrs12 replied May 19, 2015

I'm sorry about that, won't happen again. What would the accepted protocol be for eventually removing old code? A separate issue? I can file a PR which puts back in the old code if you would like

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry May 19, 2015

Member

Just keep them separate. If it's in there, most of the time it's there for a reason, and a PR to fix something else isn't the place to weigh in with personal takes on what is and isn't useful. If you don't like the behavior, that can be a separate issue and dealt with its own way (by the right people, with the right process, whatever).

Member

benfry replied May 19, 2015

Just keep them separate. If it's in there, most of the time it's there for a reason, and a PR to fix something else isn't the place to weigh in with personal takes on what is and isn't useful. If you don't like the behavior, that can be a separate issue and dealt with its own way (by the right people, with the right process, whatever).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment