New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing internationalization in app/Sketch.java #3392

Merged
merged 1 commit into from Jun 18, 2015

Conversation

Projects
None yet
2 participants
@joelmoniz
Member

joelmoniz commented Jun 16, 2015

This PR adds in a couple of key-value pairs into PDE.properties file from the app/Sketch.java that were hard-coded so far. This should complete the internationalization of app/Sketch.java.

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Jun 17, 2015

Member

Don't all those quotes need to be escaped, the way they are in the rest of the file?

Member

benfry commented Jun 17, 2015

Don't all those quotes need to be escaped, the way they are in the rest of the file?

Complete internationalization in app/Sketch.java
And remove accidental backslashes from PDE.properties
@joelmoniz

This comment has been minimized.

Show comment
Hide comment
@joelmoniz

joelmoniz Jun 18, 2015

Member

I had actually escaped them initially, but then removed the escapes when I realized that most of the file actually contained quotes that weren't escaped. I tested this out as well, and it seems that strings read in from a text file don't need anything to be escaped. I checked this out again just now, and surprisingly, strings with escaped characters when read from a file print the escaping slash as well, so something like The file \"%s\" already exists. actually shows up as The file \"sketch_150618a\" already exists., while The file "%s" already exists. shows as expected: The file "sketch_150618a" already exists.

NB: I've also updated the strings that had escaping backslashes in them and removed them.

Member

joelmoniz commented Jun 18, 2015

I had actually escaped them initially, but then removed the escapes when I realized that most of the file actually contained quotes that weren't escaped. I tested this out as well, and it seems that strings read in from a text file don't need anything to be escaped. I checked this out again just now, and surprisingly, strings with escaped characters when read from a file print the escaping slash as well, so something like The file \"%s\" already exists. actually shows up as The file \"sketch_150618a\" already exists., while The file "%s" already exists. shows as expected: The file "sketch_150618a" already exists.

NB: I've also updated the strings that had escaping backslashes in them and removed them.

benfry added a commit that referenced this pull request Jun 18, 2015

Merge pull request #3392 from joelmoniz/missingI18n
Add missing internationalization in app/Sketch.java

@benfry benfry merged commit 35beaeb into processing:master Jun 18, 2015

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Jun 18, 2015

Member

Ok, thanks for checking.

Member

benfry commented Jun 18, 2015

Ok, thanks for checking.

@joelmoniz joelmoniz deleted the joelmoniz:missingI18n branch Jun 21, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment