Fixed the NPE #3438

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@Akarshit
Member

Akarshit commented Jun 26, 2015

Fix for #3429

@@ -270,7 +270,10 @@ public boolean writePropertiesFile(File propFile) {
specifiedImport = sbImport.toString();
}
*/
- String importItem = importsList.join(",");
+ String importItem = "";
+ if(importsList != null){

This comment has been minimized.

@Akarshit

Akarshit Jun 26, 2015

Member

is this supposed to come null in most of the cases ?
Is there a contribution which needs to be tested to see if importsList is working fine ?

@Akarshit

Akarshit Jun 26, 2015

Member

is this supposed to come null in most of the cases ?
Is there a contribution which needs to be tested to see if importsList is working fine ?

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Jun 26, 2015

Member

Thanks for checking into this, my goof. I've added a cleaner fix that should do the trick.

Member

benfry commented Jun 26, 2015

Thanks for checking into this, my goof. I've added a cleaner fix that should do the trick.

@benfry benfry closed this Jun 26, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment