New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CM list converted into table #3454

Merged
merged 10 commits into from Jul 14, 2015

Conversation

Projects
None yet
2 participants
@Akarshit
Member

Akarshit commented Jul 5, 2015

@alignedleft
I thought it would be nice to do a PR before b11 is released
Things left to do

  • Handle status tab (@benfry do you think i should make a separate layout for update panel or use many ifs to reuse the current one)
  • Color-coding
  • Ellipses in the contribution name. (@benfry can you please help me in this, see the line note)
  • Remove threading(not needed any more)
  • Fix that weird bug when python mode is selected from the list.
label.setOpaque(true);
// return table.getDefaultRenderer(Icon.class).getTableCellRendererComponent(table, icon, isSelected, false, row, column);
} else if (column == 1) {
JTextPane name = new JTextPane();

This comment has been minimized.

@Akarshit

Akarshit Jul 5, 2015

Member

I can get the ellipses when this column is rendered as a string but then i wont get the contribution name in bold. To get the contribution name in bold i have to use html tags but with html the ellipses do away. So i am using JTextPane to render the name, but still am not getting the ellipses is there a easy way of getting those ellipses without loops and all.

@Akarshit

Akarshit Jul 5, 2015

Member

I can get the ellipses when this column is rendered as a string but then i wont get the contribution name in bold. To get the contribution name in bold i have to use html tags but with html the ellipses do away. So i am using JTextPane to render the name, but still am not getting the ellipses is there a easy way of getting those ellipses without loops and all.

This comment has been minimized.

@benfry

benfry Jul 14, 2015

Member

Can't you call setFont() on the JLabel?

How does the ellipsis implementation work in JLabel?

@benfry

benfry Jul 14, 2015

Member

Can't you call setFont() on the JLabel?

How does the ellipsis implementation work in JLabel?

This comment has been minimized.

@Akarshit

Akarshit Jul 14, 2015

Member

I don't have to set the font for the whole label just a part of it.

I will open a separate issue for this and look into it later.

@Akarshit

Akarshit Jul 14, 2015

Member

I don't have to set the font for the whole label just a part of it.

I will open a separate issue for this and look into it later.

benfry added a commit that referenced this pull request Jul 14, 2015

@benfry benfry merged commit 48b25eb into processing:master Jul 14, 2015

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Jul 14, 2015

Member

I'd vote for a separate layout, rather than a bunch of if statements... The CM code is messy enough as it is.

Member

benfry commented Jul 14, 2015

I'd vote for a separate layout, rather than a bunch of if statements... The CM code is messy enough as it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment