New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mode parameters from createShape(), fixes parameter collision issues #3516

Merged
merged 5 commits into from Jul 31, 2015

Conversation

Projects
None yet
2 participants
@JakubValtar
Contributor

JakubValtar commented Jul 29, 2015

Load rectMode and ellipseMode from parent.
Unify signatures and make them all work. This is the full list of available signatures:

createShape(POINT, x, y);

createShape(LINE, x1, y1, x2, y2);
createShape(LINE, x1, y1, z1, x2, y2, z2);

createShape(TRIANGLE, x1, y1, x2, y2, x3, y3);

createShape(QUAD, x1, y1, x2, y2, x3, y3, x4, y4);

createShape(RECT, a, b, c, d);
createShape(RECT, a, b, c, d, radius);
createShape(RECT, a, b, c, d, tl, tr, br, bl);

createShape(ELLIPSE, a, b, c, d);

createShape(ARC, a, b, c, d, start, stop);
createShape(ARC, a, b, c, d, start, stop, arcMode);

createShape(BOX, a);
createShape(BOX, a, b, c);

createShape(SPHERE, r);

Fixes #2646
Fixes #3018

@benfry benfry changed the title from Bugfix createshape to Remove mode parameters from createShape(), fixes method signature issues Jul 31, 2015

@benfry benfry changed the title from Remove mode parameters from createShape(), fixes method signature issues to Remove mode parameters from createShape(), fixes parameter collision issues Jul 31, 2015

benfry added a commit that referenced this pull request Jul 31, 2015

Merge pull request #3516 from JakubValtar/bugfix-createshape
Remove mode parameters from createShape(), fixes parameter collision issues

@benfry benfry merged commit ace1a33 into processing:master Jul 31, 2015

@JakubValtar JakubValtar deleted the JakubValtar:bugfix-createshape branch Aug 6, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment