New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: depth reading #3527

Merged
merged 7 commits into from Aug 4, 2015

Conversation

Projects
None yet
3 participants
@JakubValtar
Contributor

JakubValtar commented Aug 3, 2015

Adds new hint ENABLE_DEPTH_READING, which will cause multisampled PGraphics to also downsample their depth and stencil buffers (apart from color buffer).

codeanticode added a commit that referenced this pull request Aug 4, 2015

@codeanticode codeanticode merged commit cbf550d into processing:master Aug 4, 2015

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Aug 5, 2015

Member

Isn't DEPTH_READING a misnomer here when it also applies to stencil buffers?

Member

benfry commented Aug 5, 2015

Isn't DEPTH_READING a misnomer here when it also applies to stencil buffers?

@JakubValtar

This comment has been minimized.

Show comment
Hide comment
@JakubValtar

JakubValtar Aug 5, 2015

Contributor

Suggestions?

On Wed, 5 Aug 2015 08:38 Ben Fry notifications@github.com wrote:

Isn't DEPTH_READING a misnomer here when it also applies to stencil
buffers?


Reply to this email directly or view it on GitHub
#3527 (comment)
.

Contributor

JakubValtar commented Aug 5, 2015

Suggestions?

On Wed, 5 Aug 2015 08:38 Ben Fry notifications@github.com wrote:

Isn't DEPTH_READING a misnomer here when it also applies to stencil
buffers?


Reply to this email directly or view it on GitHub
#3527 (comment)
.

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Aug 5, 2015

Member

Something that makes more sense. :-)

Member

benfry commented Aug 5, 2015

Something that makes more sense. :-)

@JakubValtar JakubValtar deleted the JakubValtar:feature-depth-read branch Aug 6, 2015

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Aug 6, 2015

Member

Changed to ENABLE_BUFFER_READING, smart guy.

Member

benfry commented Aug 6, 2015

Changed to ENABLE_BUFFER_READING, smart guy.

@JakubValtar

This comment has been minimized.

Show comment
Hide comment
@JakubValtar

JakubValtar Aug 6, 2015

Contributor

Sounds good (in spite of the PGL function being called readPixels).

Contributor

JakubValtar commented Aug 6, 2015

Sounds good (in spite of the PGL function being called readPixels).

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Aug 6, 2015

Member

No second-guessing if you don't offer anything useful.

Member

benfry commented Aug 6, 2015

No second-guessing if you don't offer anything useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment