New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bar below the tab is painted #3636

Merged
merged 2 commits into from Aug 19, 2015

Conversation

Projects
None yet
3 participants
@Akarshit
Member

Akarshit commented Aug 16, 2015

Fix for #3599
Please check for compatibility with mac.

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Aug 16, 2015

Member

I'll wait for confirmation from @alignedleft

Member

benfry commented Aug 16, 2015

I'll wait for confirmation from @alignedleft

@alignedleft

This comment has been minimized.

Show comment
Hide comment
@alignedleft

alignedleft Aug 16, 2015

Member

Blue bar looks good, but why is there a gap between it and the tabs above? They should be touching; there should be no vertical space. See:

screen shot 2015-08-16 at 2 45 24 pm

Also, when you switch to the Update tab, the blue bar disappears and I see a dark gray bar. The "Updates" tab view should be consistent with the other views in this respect.

screen shot 2015-08-16 at 2 45 30 pm

Member

alignedleft commented Aug 16, 2015

Blue bar looks good, but why is there a gap between it and the tabs above? They should be touching; there should be no vertical space. See:

screen shot 2015-08-16 at 2 45 24 pm

Also, when you switch to the Update tab, the blue bar disappears and I see a dark gray bar. The "Updates" tab view should be consistent with the other views in this respect.

screen shot 2015-08-16 at 2 45 30 pm

@Akarshit

This comment has been minimized.

Show comment
Hide comment
@Akarshit

Akarshit Aug 19, 2015

Member

@alingedleft Please check if this resolves the issue now.

Member

Akarshit commented Aug 19, 2015

@alingedleft Please check if this resolves the issue now.

@alignedleft

This comment has been minimized.

Show comment
Hide comment
@alignedleft

alignedleft Aug 19, 2015

Member

No, there is still a gap. See:

screen shot 2015-08-19 at 12 36 52 pm

Also, the dark gray 1px horizontal line just above the column names should not appear. Note it appears above, and is even more noticeable in the Updates view:

screen shot 2015-08-19 at 12 36 59 pm

Member

alignedleft commented Aug 19, 2015

No, there is still a gap. See:

screen shot 2015-08-19 at 12 36 52 pm

Also, the dark gray 1px horizontal line just above the column names should not appear. Note it appears above, and is even more noticeable in the Updates view:

screen shot 2015-08-19 at 12 36 59 pm

@Akarshit

This comment has been minimized.

Show comment
Hide comment
@Akarshit

Akarshit Aug 19, 2015

Member

@alignedleft There is a separate issue for the gap. This PR was only for that bar getting painted in all the tabs. I hope that is resolved

Member

Akarshit commented Aug 19, 2015

@alignedleft There is a separate issue for the gap. This PR was only for that bar getting painted in all the tabs. I hope that is resolved

@alignedleft

This comment has been minimized.

Show comment
Hide comment
@alignedleft

alignedleft Aug 19, 2015

Member

@Akarshit sorry for that. Yes, the blue bar is now present and working, thanks!

Member

alignedleft commented Aug 19, 2015

@Akarshit sorry for that. Yes, the blue bar is now present and working, thanks!

benfry added a commit that referenced this pull request Aug 19, 2015

Merge pull request #3636 from Akarshit/gsoc-CMbar
Bar below the tab is painted

@benfry benfry merged commit 73feca7 into processing:master Aug 19, 2015

@benfry benfry referenced this pull request Aug 19, 2015

Closed

CM blue bar missing #3599

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment