FX - normalize enter key #3730

Merged
merged 1 commit into from Aug 28, 2015

Conversation

Projects
None yet
2 participants
@JakubValtar
Contributor

JakubValtar commented Aug 27, 2015

No description provided.

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Aug 27, 2015

Member

Mmm.. I don't think we want to do this. RETURN and ENTER mean different things. Or are we doing that elsewhere?

Member

benfry commented Aug 27, 2015

Mmm.. I don't think we want to do this. RETURN and ENTER mean different things. Or are we doing that elsewhere?

@JakubValtar

This comment has been minimized.

Show comment
Hide comment
@JakubValtar

JakubValtar Aug 27, 2015

Contributor
  • Java2D is returning only \n
  • FX was undefined for press/release, \r for typed
  • JOGL was \r for press/release, no typed events

We can only return one char, so no \r\n. Why don't we just make it \n
everywhere and users can replace it with System.lineSeparator() if they
want to use it as text input?

Is there any practical benefit of returning \r on some systems and \n on
other systems?

On Thu, 27 Aug 2015 18:11 Ben Fry notifications@github.com wrote:

Mmm.. I don't think we want to do this. RETURN and ENTER mean different
things. Or are we doing that elsewhere?


Reply to this email directly or view it on GitHub
#3730 (comment)
.

Contributor

JakubValtar commented Aug 27, 2015

  • Java2D is returning only \n
  • FX was undefined for press/release, \r for typed
  • JOGL was \r for press/release, no typed events

We can only return one char, so no \r\n. Why don't we just make it \n
everywhere and users can replace it with System.lineSeparator() if they
want to use it as text input?

Is there any practical benefit of returning \r on some systems and \n on
other systems?

On Thu, 27 Aug 2015 18:11 Ben Fry notifications@github.com wrote:

Mmm.. I don't think we want to do this. RETURN and ENTER mean different
things. Or are we doing that elsewhere?


Reply to this email directly or view it on GitHub
#3730 (comment)
.

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Aug 27, 2015

Member

Awesome. Well, \n it is. Is that what this patch will give us?

Member

benfry commented Aug 27, 2015

Awesome. Well, \n it is. Is that what this patch will give us?

@JakubValtar

This comment has been minimized.

Show comment
Hide comment
@JakubValtar

JakubValtar Aug 28, 2015

Contributor

Just for FX. Will send a new one for JOGL tomorrow.

On Thu, 27 Aug 2015 19:36 Ben Fry notifications@github.com wrote:

Awesome. Well, \n it is. Is that what this patch will give us?


Reply to this email directly or view it on GitHub
#3730 (comment)
.

Contributor

JakubValtar commented Aug 28, 2015

Just for FX. Will send a new one for JOGL tomorrow.

On Thu, 27 Aug 2015 19:36 Ben Fry notifications@github.com wrote:

Awesome. Well, \n it is. Is that what this patch will give us?


Reply to this email directly or view it on GitHub
#3730 (comment)
.

benfry added a commit that referenced this pull request Aug 28, 2015

@benfry benfry merged commit 17004ab into processing:master Aug 28, 2015

@JakubValtar JakubValtar deleted the JakubValtar:fx-keys branch Aug 28, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment