New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FX - add FX2D keyword, remove JFX keyword #3731

Merged
merged 1 commit into from Aug 27, 2015

Conversation

Projects
None yet
3 participants
@JakubValtar
Contributor

JakubValtar commented Aug 27, 2015

No description provided.

benfry added a commit that referenced this pull request Aug 27, 2015

Merge pull request #3731 from JakubValtar/fx-keword-highlight
FX - add FX2D keyword, remove JFX keyword

@benfry benfry merged commit 145ce10 into processing:master Aug 27, 2015

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Aug 27, 2015

Member

Whups, I just merged this, but I think that file is auto-generated. @REAS?

Member

benfry commented Aug 27, 2015

Whups, I just merged this, but I think that file is auto-generated. @REAS?

@JakubValtar

This comment has been minimized.

Show comment
Hide comment
@JakubValtar

JakubValtar Aug 27, 2015

Contributor

Auto-generated from docs? Because I don't see JFX in PConstants and I'm
fairly certain I've ant cleaned recently.

On Thu, 27 Aug 2015 18:10 Ben Fry notifications@github.com wrote:

Whups, I just merged this, but I think that file is auto-generated. @REAS
https://github.com/REAS?


Reply to this email directly or view it on GitHub
#3731 (comment)
.

Contributor

JakubValtar commented Aug 27, 2015

Auto-generated from docs? Because I don't see JFX in PConstants and I'm
fairly certain I've ant cleaned recently.

On Thu, 27 Aug 2015 18:10 Ben Fry notifications@github.com wrote:

Whups, I just merged this, but I think that file is auto-generated. @REAS
https://github.com/REAS?


Reply to this email directly or view it on GitHub
#3731 (comment)
.

@JakubValtar

This comment has been minimized.

Show comment
Hide comment
@JakubValtar

JakubValtar Aug 27, 2015

Contributor

Ah sorry, I've just read the header. I did global search and jumped right in the middle of the file.

Contributor

JakubValtar commented Aug 27, 2015

Ah sorry, I've just read the header. I did global search and jumped right in the middle of the file.

@REAS

This comment has been minimized.

Show comment
Hide comment
@REAS

REAS Aug 27, 2015

Member

Should I re-generate the file and commit it?

@JakubValtar, you can make those modifications here: https://github.com/processing/processing-docs/blob/master/generate/keywords_base.txt

You can generate the keywords file by running this Perl code:
https://github.com/processing/processing-docs/blob/master/generate/keywords_create.cgi

Member

REAS commented Aug 27, 2015

Should I re-generate the file and commit it?

@JakubValtar, you can make those modifications here: https://github.com/processing/processing-docs/blob/master/generate/keywords_base.txt

You can generate the keywords file by running this Perl code:
https://github.com/processing/processing-docs/blob/master/generate/keywords_create.cgi

@JakubValtar

This comment has been minimized.

Show comment
Hide comment
@JakubValtar

JakubValtar Aug 28, 2015

Contributor

Thanks @REAS. We want to keep these changes. Is it enough to just edit the keywords_base.txt file you linked then? I'm not sure what the Perl script actually does and if I should run it at all.

Contributor

JakubValtar commented Aug 28, 2015

Thanks @REAS. We want to keep these changes. Is it enough to just edit the keywords_base.txt file you linked then? I'm not sure what the Perl script actually does and if I should run it at all.

@REAS

This comment has been minimized.

Show comment
Hide comment
@REAS

REAS Aug 28, 2015

Member

Yes, you can update keywords_base.txt. I'll do the rest.

Member

REAS commented Aug 28, 2015

Yes, you can update keywords_base.txt. I'll do the rest.

@JakubValtar

This comment has been minimized.

Show comment
Hide comment
@JakubValtar

JakubValtar Aug 28, 2015

Contributor

Thanks Casey, I sent a PR to processing-docs. Sorry for the mess!

Contributor

JakubValtar commented Aug 28, 2015

Thanks Casey, I sent a PR to processing-docs. Sorry for the mess!

@JakubValtar JakubValtar deleted the JakubValtar:fx-keword-highlight branch Aug 31, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment