New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the remove filter feature #3890

Merged
merged 2 commits into from Nov 10, 2016

Conversation

Projects
None yet
4 participants
@Akarshit
Member

Akarshit commented Sep 28, 2015

Adds a cross button on the right side of the search field in CM. Currently a "X" is being displayed but can be replaced by a icon.
Might be a cool feature. Looks like below on linux -
screenshot from 2015-09-28 19 35 58

@Akarshit

This comment has been minimized.

Show comment
Hide comment
@Akarshit

Akarshit Dec 8, 2015

Member

@jamesjgrady @alignedleft What are your thoughts on this one ?

Member

Akarshit commented Dec 8, 2015

@jamesjgrady @alignedleft What are your thoughts on this one ?

@alignedleft

This comment has been minimized.

Show comment
Hide comment
@alignedleft

alignedleft Dec 9, 2015

Member

@Akarshit Yes, I think this is a nice idea, as long as an icon can be used that is consistent with the rest of the UI.

Member

alignedleft commented Dec 9, 2015

@Akarshit Yes, I think this is a nice idea, as long as an icon can be used that is consistent with the rest of the UI.

@Akarshit

This comment has been minimized.

Show comment
Hide comment
@Akarshit

Akarshit Dec 11, 2015

Member

@alignedleft I have added the icon. It looks like this now
screenshot from 2015-12-11 11 25 45

Member

Akarshit commented Dec 11, 2015

@alignedleft I have added the icon. It looks like this now
screenshot from 2015-12-11 11 25 45

@alignedleft

This comment has been minimized.

Show comment
Hide comment
@alignedleft

alignedleft Dec 11, 2015

Member

This looks very nice to me. @jamesjgrady would you mind just looking and letting us know if you approve?

Member

alignedleft commented Dec 11, 2015

This looks very nice to me. @jamesjgrady would you mind just looking and letting us know if you approve?

@jamesjgrady

This comment has been minimized.

Show comment
Hide comment
@jamesjgrady

jamesjgrady Dec 11, 2015

Contributor

I think the x looks fine. I don't love the dark orange highlight box. Is there anything that can be done about that, or is it OS dependent?

Contributor

jamesjgrady commented Dec 11, 2015

I think the x looks fine. I don't love the dark orange highlight box. Is there anything that can be done about that, or is it OS dependent?

@benfry benfry merged commit 9c04369 into processing:master Nov 10, 2016

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Nov 10, 2016

Member

Implemented for 3.2.4.

@jamesjgrady the orange is from Linux, on the Mac we get its selection highlight color, so yeah, it's OS dependent.

Member

benfry commented Nov 10, 2016

Implemented for 3.2.4.

@jamesjgrady the orange is from Linux, on the Mac we get its selection highlight color, so yeah, it's OS dependent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment