New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CM: Send update count to Editors #3896

Merged
merged 2 commits into from Sep 29, 2015

Conversation

Projects
None yet
2 participants
@JakubValtar
Contributor

JakubValtar commented Sep 28, 2015

Requested for #3518

See #3518 (comment)

benfry added a commit that referenced this pull request Sep 29, 2015

@benfry benfry merged commit 78fc192 into processing:master Sep 29, 2015

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Sep 29, 2015

Member

Much thank you.

Member

benfry commented Sep 29, 2015

Much thank you.

@JakubValtar

This comment has been minimized.

Show comment
Hide comment
@JakubValtar

JakubValtar Sep 29, 2015

Contributor

I just figured out: if you open new Editor window, it should be able to get the update count and display it, so we might want to store the update count in Base and let the Editor query it on startup.

Contributor

JakubValtar commented Sep 29, 2015

I just figured out: if you open new Editor window, it should be able to get the update count and display it, so we might want to store the update count in Base and let the Editor query it on startup.

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Sep 29, 2015

Member

The issue is that it (also) needs to be event driven, because the number will change as updates happen.

Member

benfry commented Sep 29, 2015

The issue is that it (also) needs to be event driven, because the number will change as updates happen.

@JakubValtar

This comment has been minimized.

Show comment
Hide comment
@JakubValtar

JakubValtar Sep 29, 2015

Contributor

Yes, event driven is already in place and there to stay. I was mentioning a situation when you have the PDE running and you open a new Editor window, the Editor has to get the update count somewhere because there will be no event from the Contribution Manager.

Contributor

JakubValtar commented Sep 29, 2015

Yes, event driven is already in place and there to stay. I was mentioning a situation when you have the PDE running and you open a new Editor window, the Editor has to get the update count somewhere because there will be no event from the Contribution Manager.

@JakubValtar JakubValtar deleted the JakubValtar:cm-update-count branch Sep 29, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment