New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small usability fixes for tiny screens, take 2 #3999

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@gohai
Contributor

gohai commented Oct 14, 2015

This implements @jamesjgrady's suggestion from #3992.

@gohai

This comment has been minimized.

Show comment
Hide comment
@gohai

gohai Oct 14, 2015

Contributor

Screenshots attached. (The less wide editor window looks so much better to me - perhaps it would really make sense to resize the window proportionally if it the default doesn't fit onto the screen? Maybe we could spawn it at 0,0 in this case too. This way the play/stop buttons are most likely to be unobstructed.)

2015-10-14-155244_800x480_scrot
2015-10-14-155014_800x480_scrot

Contributor

gohai commented Oct 14, 2015

Screenshots attached. (The less wide editor window looks so much better to me - perhaps it would really make sense to resize the window proportionally if it the default doesn't fit onto the screen? Maybe we could spawn it at 0,0 in this case too. This way the play/stop buttons are most likely to be unobstructed.)

2015-10-14-155244_800x480_scrot
2015-10-14-155014_800x480_scrot

@gohai

This comment has been minimized.

Show comment
Hide comment
@gohai

gohai Oct 14, 2015

Contributor

Another alternative would be to keep the initial behavior, but make it so that the display window spawns right next to the stop button. So like my initial patch, but keeping the 66px from the top - just pushing it more to the right so that the user can click stop.

Contributor

gohai commented Oct 14, 2015

Another alternative would be to keep the initial behavior, but make it so that the display window spawns right next to the stop button. So like my initial patch, but keeping the 66px from the top - just pushing it more to the right so that the user can click stop.

@benfry benfry added this to the 3.0.1 milestone Oct 23, 2015

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Oct 23, 2015

Member

Going with a hybrid of the two PRs for 3.0.1.

Member

benfry commented Oct 23, 2015

Going with a hybrid of the two PRs for 3.0.1.

@benfry benfry closed this Oct 23, 2015

@gohai gohai deleted the gohai:for-ben-15 branch Nov 2, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment