Add error checker document listeners to all tabs #4009

Merged
merged 1 commit into from Oct 20, 2015

Conversation

Projects
None yet
2 participants
@JakubValtar
Contributor

JakubValtar commented Oct 16, 2015

Check if #3983 is still an issue

benfry added a commit that referenced this pull request Oct 20, 2015

Merge pull request #4009 from JakubValtar/error-checker-document-list…
…eners

Add error checker document listeners to all tabs

@benfry benfry merged commit 33aa35a into processing:master Oct 20, 2015

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Oct 20, 2015

Member

Not sure if this will do anything—it may use the same Document object across all tabs. (But that code is really old and I didn't look into it closely.)

Member

benfry commented Oct 20, 2015

Not sure if this will do anything—it may use the same Document object across all tabs. (But that code is really old and I didn't look into it closely.)

@JakubValtar

This comment has been minimized.

Show comment
Hide comment
@JakubValtar

JakubValtar Oct 20, 2015

Contributor

I checked all the accessors, each tab has its own SyntaxDocument. This solves an issue that all tabs except for the first one won't trigger error checker on typing, it was triggered only when you switched tabs. The reason was missing listeners. With this fix, each document should get a listener either on startup as soon as the error checker is initialized or when the document is set.

After next release we need to check with #3983 if he still has an issue. Not enough info there to know.

Contributor

JakubValtar commented Oct 20, 2015

I checked all the accessors, each tab has its own SyntaxDocument. This solves an issue that all tabs except for the first one won't trigger error checker on typing, it was triggered only when you switched tabs. The reason was missing listeners. With this fix, each document should get a listener either on startup as soon as the error checker is initialized or when the document is set.

After next release we need to check with #3983 if he still has an issue. Not enough info there to know.

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Oct 20, 2015

Member

Cool, thanks.

Member

benfry commented Oct 20, 2015

Cool, thanks.

@JakubValtar JakubValtar deleted the JakubValtar:error-checker-document-listeners branch Oct 22, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment