New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved fix for Issue #4017 where tweak mode ignores some numbers in a second tab #4023

Merged
merged 2 commits into from Oct 20, 2015

Conversation

Projects
None yet
3 participants
@erniejunior
Contributor

erniejunior commented Oct 18, 2015

This is an improved version of my previous pull request after some friendly hints by @galsasson. This one has even less changes and should be more transparent.
We now maintain the ignore-lists for functions in separate lists for the different tabs.

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Oct 19, 2015

Member

@galsasson will wait for your initial approval...

Member

benfry commented Oct 19, 2015

@galsasson will wait for your initial approval...

@galsasson

This comment has been minimized.

Show comment
Hide comment
@galsasson

galsasson Oct 20, 2015

Contributor

There is a warning related to the use of Collections.EMPTY_LIST. I'm not fluent with java, but I think its fine. ?
Other that that it works and fixes the issue, thanks @erniejunior

Contributor

galsasson commented Oct 20, 2015

There is a warning related to the use of Collections.EMPTY_LIST. I'm not fluent with java, but I think its fine. ?
Other that that it works and fixes the issue, thanks @erniejunior

@erniejunior

This comment has been minimized.

Show comment
Hide comment
@erniejunior

erniejunior Oct 20, 2015

Contributor

Hi, @galsasson the warning is because the EMPTY_LIST is not typed (we do not specify what type of items it contains via generics). Since it is empty it does not really matter. But we could get rid of it by using ignoreFunctions.add(new LinkedList<SketchParser.Range>()); (just create an empty linked list). But I thought that explicitly spelling out that the list is empty improves readability.

Contributor

erniejunior commented Oct 20, 2015

Hi, @galsasson the warning is because the EMPTY_LIST is not typed (we do not specify what type of items it contains via generics). Since it is empty it does not really matter. But we could get rid of it by using ignoreFunctions.add(new LinkedList<SketchParser.Range>()); (just create an empty linked list). But I thought that explicitly spelling out that the list is empty improves readability.

benfry added a commit that referenced this pull request Oct 20, 2015

Merge pull request #4023 from erniejunior/master
Improved fix for Issue #4017 where tweak mode ignores some numbers in a second tab

@benfry benfry merged commit a1bd718 into processing:master Oct 20, 2015

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Oct 20, 2015

Member

Thanks all.

Member

benfry commented Oct 20, 2015

Thanks all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment