New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CM - Icon instead of an "X" for the "could not connect" message #3706 #4055

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@iamutkarshtiwari
Contributor

iamutkarshtiwari commented Oct 23, 2015

This patch is a fix to this issue -> #3706

With this patch, the CM "Could not connect" message will dispaly the cross icon as shown in the image below.
cross

@@ -628,6 +628,9 @@
<!--<fileset dir="shared" includes="launch4j/**" />-->
<fileset dir="shared" includes="lib/**" excludes="lib/fonts/**" />
<fileset file="shared/revisions.txt" />

This comment has been minimized.

@iamutkarshtiwari

iamutkarshtiwari Oct 23, 2015

Contributor

I have added _two spaces_ here to _avoid merge conflicts_ with my other pending Pull Requests which modify this same file.

@iamutkarshtiwari

iamutkarshtiwari Oct 23, 2015

Contributor

I have added _two spaces_ here to _avoid merge conflicts_ with my other pending Pull Requests which modify this same file.

@@ -774,6 +777,9 @@
<fileset dir="shared" includes="lib/**" excludes="lib/fonts/**" />
<fileset dir="shared" includes="modes/**" />
<fileset file="shared/revisions.txt" />

This comment has been minimized.

@iamutkarshtiwari

iamutkarshtiwari Oct 23, 2015

Contributor

I have added _two spaces_ here to _avoid merge conflicts_ with my other pending Pull Requests which modify this same file.

@iamutkarshtiwari

iamutkarshtiwari Oct 23, 2015

Contributor

I have added _two spaces_ here to _avoid merge conflicts_ with my other pending Pull Requests which modify this same file.

@@ -1062,6 +1068,9 @@
<fileset dir="shared" includes="lib/**" excludes="lib/fonts/**" />
<fileset dir="shared" includes="modes/**" />
<fileset file="shared/revisions.txt" />

This comment has been minimized.

@iamutkarshtiwari

iamutkarshtiwari Oct 23, 2015

Contributor

I have added _two spaces_ here to _avoid merge conflicts_ with my other pending Pull Requests which modify this same file.

@iamutkarshtiwari

iamutkarshtiwari Oct 23, 2015

Contributor

I have added _two spaces_ here to _avoid merge conflicts_ with my other pending Pull Requests which modify this same file.

@Akarshit

This comment has been minimized.

Show comment
Hide comment
@Akarshit

Akarshit Oct 31, 2015

Member

It would be awesome if @alignedleft could provide icon for this.

Member

Akarshit commented Oct 31, 2015

It would be awesome if @alignedleft could provide icon for this.

@alignedleft

This comment has been minimized.

Show comment
Hide comment
@alignedleft

alignedleft Nov 1, 2015

Member

I'd like to make sure @jamesjgrady reviews and gives the OK for this approach first. Then I believe he already has an icon that could be adapted here.

Member

alignedleft commented Nov 1, 2015

I'd like to make sure @jamesjgrady reviews and gives the OK for this approach first. Then I believe he already has an icon that could be adapted here.

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Nov 2, 2015

Member

We can't use this PR as-is, it installs the image in a different location from the other image assets that are used elsewhere in the Contribution Manager, and also doesn't have retina support. To implement this properly, it should use the same methods as all the other GUI elements in the CM.

Member

benfry commented Nov 2, 2015

We can't use this PR as-is, it installs the image in a different location from the other image assets that are used elsewhere in the Contribution Manager, and also doesn't have retina support. To implement this properly, it should use the same methods as all the other GUI elements in the CM.

@benfry benfry closed this Nov 2, 2015

@iamutkarshtiwari

This comment has been minimized.

Show comment
Hide comment
@iamutkarshtiwari

iamutkarshtiwari Nov 2, 2015

Contributor

@benfry How to implement the retina support ?

Contributor

iamutkarshtiwari commented Nov 2, 2015

@benfry How to implement the retina support ?

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Nov 5, 2015

Member

Look at the methods used for all the other GUI images in the Contribution Manager code.

Member

benfry commented Nov 5, 2015

Look at the methods used for all the other GUI images in the Contribution Manager code.

@iamutkarshtiwari

This comment has been minimized.

Show comment
Hide comment
@iamutkarshtiwari
Contributor

iamutkarshtiwari commented Nov 5, 2015

benfry added a commit that referenced this pull request Feb 14, 2016

Merge pull request #4096 from iamutkarshtiwari/bugfix-IconInsteadOfX
Icon instead of an "X" for the "could not connect" message #3706 #4055
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment