New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crashing bugs that happen when the user's name has non-ASCII characters on Windows. #4204

Merged
merged 2 commits into from Feb 14, 2016

Conversation

Projects
None yet
2 participants
@jdf
Contributor

jdf commented Dec 16, 2015

No description provided.

jdf added some commits Dec 16, 2015

@jdf jdf changed the title from Make it possible to run PDE in Eclipse on Windows, or on any platform where the path may have URL-encoded characters in it. to Fix crashing bugs that happen when the user's name has non-ASCII characters on Windows. Dec 16, 2015

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Dec 16, 2015

Member

Is this just when running from Eclipse on Windows?

Member

benfry commented Dec 16, 2015

Is this just when running from Eclipse on Windows?

@jdf

This comment has been minimized.

Show comment
Hide comment
@jdf

jdf Dec 16, 2015

Contributor

There are two commits; one addressed an Eclipse-on-Windows bug (which could potentially fail on other platforms, too), and the other addresses a crashing bug when running a release build of the PDE.

Contributor

jdf commented Dec 16, 2015

There are two commits; one addressed an Eclipse-on-Windows bug (which could potentially fail on other platforms, too), and the other addresses a crashing bug when running a release build of the PDE.

@jdf jdf referenced this pull request Dec 24, 2015

Closed

Python mode fails to run #135

@jdf

This comment has been minimized.

Show comment
Hide comment
@jdf

jdf Jan 16, 2016

Contributor

Ping?

Contributor

jdf commented Jan 16, 2016

Ping?

benfry added a commit that referenced this pull request Feb 14, 2016

Merge pull request #4204 from jdf/master
Fix crashing bugs that happen when the user's name has non-ASCII characters on Windows.

@benfry benfry merged commit 42ee76b into processing:master Feb 14, 2016

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Feb 14, 2016

Member

Thanks for the fix. Does this also cover #3543?

Member

benfry commented Feb 14, 2016

Thanks for the fix. Does this also cover #3543?

@jdf

This comment has been minimized.

Show comment
Hide comment
@jdf

jdf Feb 14, 2016

Contributor

I can't say offhand; it depends on the codepath font loading uses.

Contributor

jdf commented Feb 14, 2016

I can't say offhand; it depends on the codepath font loading uses.

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry May 9, 2016

Member

(For the record, this doesn't fix #3543, which is based on a launch4j bug.)

Member

benfry commented May 9, 2016

(For the record, this doesn't fix #3543, which is based on a launch4j bug.)

@jdf

This comment has been minimized.

Show comment
Hide comment
@jdf

jdf May 10, 2016

Contributor

argh, and thank you!

Contributor

jdf commented May 10, 2016

argh, and thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment