Fixes for Chinese/Japanese/Korean InputMethod support #4293

Merged
merged 1 commit into from Feb 14, 2016

Conversation

Projects
None yet
3 participants
@satoshiokita
Contributor

satoshiokita commented Feb 13, 2016

current InputMethod of syntax.im package was only support Japanese. the Japanese Input Method and Chinese Input Method(this called pinyin) are similar system. but Korean Input Method is not.
I rewrited code for CJK support. and I tested only Windows8.1 64bit(Japanese).
I dont test Mac OSX. (need test)

fixed issue list

#2968
#3860
#3475

Input Method key

Language Commited text Trigger Key toggle key to english
Japanese Enter key or space key hankaku Key
Chiese(Pinyin) space key left shift key
Chiese(Bopomofo) space key left shift key
Korean(Hangl) NO right alt key

screenshot

korean
01

japanese
02

chinese
03
#3475 fixed

issue3475

add to fiexed the composed text is shown doubly.
change to cjk support from japanese only

remove code depend on textManager.
clean comment outed old code.

rewirte getTextLocation method to simple logic

benfry added a commit that referenced this pull request Feb 14, 2016

Merge pull request #4293 from satoshiokita/FIX-InputMethodCJKSupport
Fixed InputMethod Chiese/Japanese/Korean support.

@benfry benfry merged commit 64446fa into processing:master Feb 14, 2016

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Feb 14, 2016

Member

Awesome! Thank you. I'll have to trust you that this is working, and hopefully others can weigh in.

So great to have some help with these issues!

Member

benfry commented Feb 14, 2016

Awesome! Thank you. I'll have to trust you that this is working, and hopefully others can weigh in.

So great to have some help with these issues!

@benfry benfry changed the title from Fixed InputMethod Chiese/Japanese/Korean support. to Fixes for Chinese/Japanese/Korean InputMethod support Feb 14, 2016

@Myriads

This comment has been minimized.

Show comment
Hide comment
@Myriads

Myriads Feb 14, 2016

Thank you for your fixing Korean Input method issues.

There are some minor problems related to the caret location and background color. Normally caret is located at the right side of the composing Korean character. But caret is located at the left side. Please refer to the attached 2 pictures: one is 3.0.1 IDE and the other is 3.0.2 IDE.

processing_caret_01
processing_caret_02

Myriads commented Feb 14, 2016

Thank you for your fixing Korean Input method issues.

There are some minor problems related to the caret location and background color. Normally caret is located at the right side of the composing Korean character. But caret is located at the left side. Please refer to the attached 2 pictures: one is 3.0.1 IDE and the other is 3.0.2 IDE.

processing_caret_01
processing_caret_02

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Feb 14, 2016

Member

Ah, could you post that as a new bug?

Member

benfry commented Feb 14, 2016

Ah, could you post that as a new bug?

@satoshiokita satoshiokita deleted the satoshiokita:FIX-InputMethodCJKSupport branch Feb 16, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment