New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncomment identation fix #4249 #4313

Merged
merged 1 commit into from May 9, 2016

Conversation

Projects
None yet
3 participants
@DarkPrince304
Contributor

DarkPrince304 commented Feb 18, 2016

Hello,

With this I think the issue #4249 is fixed and uncommenting the lines wont reduce the identation, and it will remain the way it was before uncommenting. :)

Would like to have some review on this!

@JakubValtar

This comment has been minimized.

Show comment
Hide comment
@JakubValtar

JakubValtar May 9, 2016

Contributor

@DarkPrince304 Thanks!

@benfry Let's merge this for 3.1.1

Contributor

JakubValtar commented May 9, 2016

@DarkPrince304 Thanks!

@benfry Let's merge this for 3.1.1

@benfry benfry merged commit 34c5a63 into processing:master May 9, 2016

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry May 9, 2016

Member

@JakubValtar also see note I just added here as you're looking into this further.

Member

benfry commented May 9, 2016

@JakubValtar also see note I just added here as you're looking into this further.

@JakubValtar

This comment has been minimized.

Show comment
Hide comment
@JakubValtar

JakubValtar May 9, 2016

Contributor

@benfry There was no space being added. However, if there was a space after the slashes, it got deleted (fixed by this PR).

I'm personally used to slashes being added to the left border (zero line offset), now they are added after indent and it makes the code messy. Do you think it would be better idea?

Also the keyboard shortcut doesn't work on my keyboard, I will have to fix it too.

Contributor

JakubValtar commented May 9, 2016

@benfry There was no space being added. However, if there was a space after the slashes, it got deleted (fixed by this PR).

I'm personally used to slashes being added to the left border (zero line offset), now they are added after indent and it makes the code messy. Do you think it would be better idea?

Also the keyboard shortcut doesn't work on my keyboard, I will have to fix it too.

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry May 9, 2016

Member

I was used to the slashes going at the beginning of the line, but relented because we got so many requests to change it.

When the new version was contributed, an additional space was added (since that's now the style of many editors... perhaps Sublime in particular?) I removed that with the later commit that was referenced.

Member

benfry commented May 9, 2016

I was used to the slashes going at the beginning of the line, but relented because we got so many requests to change it.

When the new version was contributed, an additional space was added (since that's now the style of many editors... perhaps Sublime in particular?) I removed that with the later commit that was referenced.

@JakubValtar

This comment has been minimized.

Show comment
Hide comment
@JakubValtar

JakubValtar May 9, 2016

Contributor

Okay, now it should be fully functional, I'm just going to fix the keyboard shortcut.

Contributor

JakubValtar commented May 9, 2016

Okay, now it should be fully functional, I'm just going to fix the keyboard shortcut.

@JakubValtar

This comment has been minimized.

Show comment
Hide comment
@JakubValtar

JakubValtar May 9, 2016

Contributor

Shortcut follow up: #4457

Contributor

JakubValtar commented May 9, 2016

Shortcut follow up: #4457

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment