Friendlier error message for HidingEnclosingType #4337

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
3 participants
@rzats
Contributor

rzats commented Feb 28, 2016

This PR fixes #4228

@rzats rzats changed the title from Friendlier error message for HidingEnclosingType; fixes #4228 to Friendlier error message for HidingEnclosingType Feb 28, 2016

@Akarshit

This comment has been minimized.

Show comment
Hide comment
@Akarshit

Akarshit Feb 29, 2016

Member

@rzats Don't you think doing this would change the error message wherever an error of this type is occurring.
For example the code below would give the error message The class Hello cannot have the same name as the name of your sketch

void setup(){
  size(300,300);
}
class Hello{
  int a;
  class Hello{
    int b;
  }
}
Member

Akarshit commented Feb 29, 2016

@rzats Don't you think doing this would change the error message wherever an error of this type is occurring.
For example the code below would give the error message The class Hello cannot have the same name as the name of your sketch

void setup(){
  size(300,300);
}
class Hello{
  int a;
  class Hello{
    int b;
  }
}
@rzats

This comment has been minimized.

Show comment
Hide comment
@rzats

rzats Feb 29, 2016

Contributor

@Akarshit This makes sense - I've updated the preproc logic so that it actually checks the sketch name.

Contributor

rzats commented Feb 29, 2016

@Akarshit This makes sense - I've updated the preproc logic so that it actually checks the sketch name.

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry May 8, 2016

Member

@rzats can you re-submit with the current version of the repo?

Member

benfry commented May 8, 2016

@rzats can you re-submit with the current version of the repo?

@rzats

This comment has been minimized.

Show comment
Hide comment
@rzats

rzats May 8, 2016

Contributor

@benfry: sure - I'll open a new PR for this because syncing's going to be a bit hard at this point.

Contributor

rzats commented May 8, 2016

@benfry: sure - I'll open a new PR for this because syncing's going to be a bit hard at this point.

@rzats rzats closed this May 8, 2016

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry May 8, 2016

Member

Thanks!

Member

benfry commented May 8, 2016

Thanks!

@rzats

This comment has been minimized.

Show comment
Hide comment
@rzats

rzats May 8, 2016

Contributor

Resubmitted at #4451.

Contributor

rzats commented May 8, 2016

Resubmitted at #4451.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment