New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore memory options when exporting for ARM #4406

Merged
merged 1 commit into from May 8, 2016

Conversation

Projects
None yet
3 participants
@gohai
Contributor

gohai commented Apr 14, 2016

I had students export a sketch on their laptops and try it out on a Raspberry Pi, but this failed for most, since their memory settings in Preferences were at insanely high values. Perhaps for the time being, we could ignore those for ARM?

@gohai

This comment has been minimized.

Show comment
Hide comment
@gohai

gohai Apr 14, 2016

Contributor

(Tested by exporting on Mac, btw)

Contributor

gohai commented Apr 14, 2016

(Tested by exporting on Mac, btw)

@gohai gohai added the arm label Apr 19, 2016

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry May 7, 2016

Member

Hm... what's a better solution here? Do we repeat the memory preference when exporting for ARM, so that folks can turn it off? Without this, people have no control over memory on ARM.

Or... is it the case that there isn't much memory control anyway, so this solution will work in the short (next 12-18 months) term?

Member

benfry commented May 7, 2016

Hm... what's a better solution here? Do we repeat the memory preference when exporting for ARM, so that folks can turn it off? Without this, people have no control over memory on ARM.

Or... is it the case that there isn't much memory control anyway, so this solution will work in the short (next 12-18 months) term?

@gohai

This comment has been minimized.

Show comment
Hide comment
@gohai

gohai May 7, 2016

Contributor

Another idea: we could add a little bit of shell magic to the startup script on Linux to make it so that we request min(memoryRequested, memoryAvailable). There is /proc/meminfo, which is pretty easy to parse, and should be available pretty much everywhere.

But you're right, there isn't much memory to control anyway :)

Contributor

gohai commented May 7, 2016

Another idea: we could add a little bit of shell magic to the startup script on Linux to make it so that we request min(memoryRequested, memoryAvailable). There is /proc/meminfo, which is pretty easy to parse, and should be available pretty much everywhere.

But you're right, there isn't much memory to control anyway :)

@benfry benfry merged commit 79b45f3 into processing:master May 8, 2016

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry May 8, 2016

Member

I think the benefits here outweigh the potential issues, at least for the next year or three.

Member

benfry commented May 8, 2016

I think the benefits here outweigh the potential issues, at least for the next year or three.

@gohai gohai deleted the gohai:arm-export-memory branch May 8, 2016

@festiberico

This comment has been minimized.

Show comment
Hide comment
@festiberico

festiberico May 11, 2016

I am coding in RPI and exporting for ARM. Precisely because I do not have a lot of memory (and I need to preload a number of images) I need to set it to 512M before exporting. If the exporter would ignore the settings in preferences that would create a further problem. Then I would regard the exporting as broken and need to avoid it altogether :(.
If it works as it should, why break it on RPI? Users exporting from other machines should check the memory or get a warning instead of crippling the export for everyone, specially those that run the machines target of the export.
ps. I would like to avoid breaking the export and even finally opened an account to comment.

festiberico commented May 11, 2016

I am coding in RPI and exporting for ARM. Precisely because I do not have a lot of memory (and I need to preload a number of images) I need to set it to 512M before exporting. If the exporter would ignore the settings in preferences that would create a further problem. Then I would regard the exporting as broken and need to avoid it altogether :(.
If it works as it should, why break it on RPI? Users exporting from other machines should check the memory or get a warning instead of crippling the export for everyone, specially those that run the machines target of the export.
ps. I would like to avoid breaking the export and even finally opened an account to comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment