New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Comment/Uncomment trigger on numpad slash #4457

Merged
merged 1 commit into from May 10, 2016

Conversation

Projects
None yet
2 participants
@JakubValtar
Contributor

JakubValtar commented May 9, 2016

No description provided.

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry May 9, 2016

Member

Really this is #2199. Are you proposing this as a band-aid until we can get to that one?

Member

benfry commented May 9, 2016

Really this is #2199. Are you proposing this as a band-aid until we can get to that one?

@JakubValtar

This comment has been minimized.

Show comment
Hide comment
@JakubValtar

JakubValtar May 9, 2016

Contributor

It's not, they are two different keys. I tested on US layout and on Czech layout. Numpad slash is VK_DIVIDE and regular slash is VK_SLASH. And there is no way known to me in their terrible API to add second accelerator key to the menu item.

Contributor

JakubValtar commented May 9, 2016

It's not, they are two different keys. I tested on US layout and on Czech layout. Numpad slash is VK_DIVIDE and regular slash is VK_SLASH. And there is no way known to me in their terrible API to add second accelerator key to the menu item.

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry May 9, 2016

Member

Heh, I understand that. I'm asking if this a patch to paper over #2199 so that it works on your keyboard (and others) until we have a better way of specifying a better shortcut for non-US keyboards?

Member

benfry commented May 9, 2016

Heh, I understand that. I'm asking if this a patch to paper over #2199 so that it works on your keyboard (and others) until we have a better way of specifying a better shortcut for non-US keyboards?

@JakubValtar

This comment has been minimized.

Show comment
Hide comment
@JakubValtar

JakubValtar May 9, 2016

Contributor

No, this has nothing to do with locale. It does not work on any numpad, because slash on numpad is considered to be a different key than slash in the letter part on every keyboard. Menu item is set up for VK_SLASH, but that does not cover numpad slash key, which is VK_DIVIDE. I believe that unless we have one listener for each key, it will not work with both keys.

Contributor

JakubValtar commented May 9, 2016

No, this has nothing to do with locale. It does not work on any numpad, because slash on numpad is considered to be a different key than slash in the letter part on every keyboard. Menu item is set up for VK_SLASH, but that does not cover numpad slash key, which is VK_DIVIDE. I believe that unless we have one listener for each key, it will not work with both keys.

@JakubValtar

This comment has been minimized.

Show comment
Hide comment
@JakubValtar

JakubValtar May 10, 2016

Contributor

Just to make things clear: this is about numpad slash. Comment/Uncomment in other apps is often mapped to Ctrl+Slash and it always works with this key. This PR adds listener for this slash in all layouts.

keyboard2

Contributor

JakubValtar commented May 10, 2016

Just to make things clear: this is about numpad slash. Comment/Uncomment in other apps is often mapped to Ctrl+Slash and it always works with this key. This PR adds listener for this slash in all layouts.

keyboard2

@benfry benfry merged commit aad493e into processing:master May 10, 2016

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry May 10, 2016

Member

I can't stop laughing that even though I said I understood that these were different keys, you still had to make an image for me. We miss you back here in Boston.

Member

benfry commented May 10, 2016

I can't stop laughing that even though I said I understood that these were different keys, you still had to make an image for me. We miss you back here in Boston.

@JakubValtar

This comment has been minimized.

Show comment
Hide comment
@JakubValtar

JakubValtar May 10, 2016

Contributor

Looks like their API is so bad it makes people dumb. I spent an hour with it before I figured it out and look at this.

Contributor

JakubValtar commented May 10, 2016

Looks like their API is so bad it makes people dumb. I spent an hour with it before I figured it out and look at this.

@JakubValtar JakubValtar deleted the JakubValtar:comment-key-fix branch May 13, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment