New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show warning message if mode cannot be changed #4559

Merged
merged 1 commit into from Jul 29, 2016

Conversation

Projects
None yet
2 participants
@tyfkda
Contributor

tyfkda commented Jul 3, 2016

If you try to change the mode which is not compatible with the current mode,
the mode change is canceled silently and different mode is checked in mode menu popup.

Reproducing this issue:

  1. Install Python mode.
  2. Select Python mode.
  3. Load any sample sketch.
  4. Click mode menu popup, and select Java.
  5. No message is shown and Java is checked in popup (but keeps Python mode.)

This change fixes the issue,
if selected mode cannot handle current source,
show warning dialog and reselect old (current) mode.

This change added text strings for English and Japanese only.

Related #2615

Show warning message if mode cannot be changed
If selected mode cannot handle current source,
show warning dialog and reselect old (current) mode.
@tyfkda

This comment has been minimized.

Show comment
Hide comment
@tyfkda

tyfkda Jul 29, 2016

Contributor

@benfry I've fixed the conflict, so would you please take a look? Thanks!

Contributor

tyfkda commented Jul 29, 2016

@benfry I've fixed the conflict, so would you please take a look? Thanks!

@benfry benfry merged commit 97399b6 into processing:master Jul 29, 2016

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Jul 29, 2016

Member

Thanks, let's give it a try for 3.1.2.

Member

benfry commented Jul 29, 2016

Thanks, let's give it a try for 3.1.2.

@tyfkda tyfkda deleted the tyfkda:feature/revert-mode-change branch Jul 29, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment