New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix running PDE from network locations #4582

Merged
merged 2 commits into from Jul 28, 2016

Conversation

Projects
None yet
2 participants
@JakubValtar
Contributor

JakubValtar commented Jul 22, 2016

Fixes #4417

Java has problems dealing with UNC paths. See http://wiki.eclipse.org/Eclipse/UNC_Paths#Programming_with_UNC_paths to get an idea how bad it is. Scheme specific part should contain the whole decoded URI except the protocol name and following colon, which should shield us from Java parsing URL parts incorrectly.

JakubValtar added some commits Jul 22, 2016

Fix running PDE from network locations
Java has problems dealing with UNC paths. See
http://wiki.eclipse.org/Eclipse/UNC_Paths#Programming_with_UNC_paths to
get an idea how bad it is. Scheme specific part should contain the whole
decoded URI except the protocol name and following colon, which should
shield us from Java parsing URL parts incorrectly.

@benfry benfry merged commit ce704e2 into processing:master Jul 28, 2016

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Jul 28, 2016

Member

Incorporated for 3.1.2.

Member

benfry commented Jul 28, 2016

Incorporated for 3.1.2.

@JakubValtar JakubValtar deleted the JakubValtar:fix-network-locations branch Aug 6, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment