New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set text color for InputMethod #4593

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@tyfkda
Contributor

tyfkda commented Aug 1, 2016

It is difficult to see the editing text,
because default text color might be similar to the background color:

ss

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Aug 1, 2016

Member

What's normal for this sort of thing in other editors? The 'before' seems like a bug, but the 'after' doesn't feel any more standard. What's the best way to handle this?

Member

benfry commented Aug 1, 2016

What's normal for this sort of thing in other editors? The 'before' seems like a bug, but the 'after' doesn't feel any more standard. What's the best way to handle this?

@tyfkda

This comment has been minimized.

Show comment
Hide comment
@tyfkda

tyfkda Aug 1, 2016

Contributor

There is underline, so we can recognize editing text and I think this is standard way (and I don't change anything other than text color in this PR).

Other screenshot: Notepad (Windows):
notepad

Contributor

tyfkda commented Aug 1, 2016

There is underline, so we can recognize editing text and I think this is standard way (and I don't change anything other than text color in this PR).

Other screenshot: Notepad (Windows):
notepad

@tyfkda

This comment has been minimized.

Show comment
Hide comment
@tyfkda

tyfkda Aug 1, 2016

Contributor

Google Chrome textarea (Windows):
chrome_textarea

Sorry for the dense screenshot, you can see the full size image by clicking it.

Contributor

tyfkda commented Aug 1, 2016

Google Chrome textarea (Windows):
chrome_textarea

Sorry for the dense screenshot, you can see the full size image by clicking it.

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Aug 4, 2016

Member

Ok, so this solution is a good start, though we should also set the background highlight color as well to the light blue. Could you take a look at adding that?

Member

benfry commented Aug 4, 2016

Ok, so this solution is a good start, though we should also set the background highlight color as well to the light blue. Could you take a look at adding that?

@tyfkda

This comment has been minimized.

Show comment
Hide comment
@tyfkda

tyfkda Aug 4, 2016

Contributor

I see.
I have changed to use same foreground/background color with the editor.

Contributor

tyfkda commented Aug 4, 2016

I see.
I have changed to use same foreground/background color with the editor.

benfry added a commit that referenced this pull request Aug 5, 2016

benfry added a commit that referenced this pull request Aug 5, 2016

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Aug 5, 2016

Member

Thanks for this. I've now incorporated your changes using a slightly different method, but they're now in there. Please give them a check to make sure I integrated them properly.

Member

benfry commented Aug 5, 2016

Thanks for this. I've now incorporated your changes using a slightly different method, but they're now in there. Please give them a check to make sure I integrated them properly.

@tyfkda tyfkda closed this Aug 6, 2016

@tyfkda tyfkda deleted the tyfkda:feature/im-text-color branch Aug 6, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment