New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set sketch as modified when any character committed using input method #4599

Merged
merged 1 commit into from Aug 4, 2016

Conversation

Projects
None yet
2 participants
@tyfkda
Contributor

tyfkda commented Aug 2, 2016

Currently, when a user input any character using input method support, sketch is not marked as modified.

So no dialog popped up when the user tried to close the window or quit the application and lost the changes.

@benfry benfry merged commit ebe9418 into processing:master Aug 4, 2016

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Aug 4, 2016

Member

Ouch, that's serious. Given this, I'll also incorporate a version of #4594 so that we're not firing that callback incessantly.

Member

benfry commented Aug 4, 2016

Ouch, that's serious. Given this, I'll also incorporate a version of #4594 so that we're not firing that callback incessantly.

benfry added a commit that referenced this pull request Aug 4, 2016

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Aug 4, 2016

Member

Merged this and multiple other edits; please give it a try.

Member

benfry commented Aug 4, 2016

Merged this and multiple other edits; please give it a try.

@tyfkda tyfkda deleted the tyfkda:feature/im branch Aug 4, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment