New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup createFont #4641

Merged
merged 1 commit into from Sep 4, 2016

Conversation

Projects
None yet
2 participants
@gohai
Contributor

gohai commented Aug 28, 2016

Wanted to at least remove the misleading comment that the last fallback is for Linux only, but ended up removing the other cases too (which are hopefully not needed anymore).

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Aug 29, 2016

Member

Can't incorporate this until someone tests the change across all platforms: Windows, macOS, Linux, and when running from ant run, from Eclipse (at least on OS X), and in a build from ant dist.

Member

benfry commented Aug 29, 2016

Can't incorporate this until someone tests the change across all platforms: Windows, macOS, Linux, and when running from ant run, from Eclipse (at least on OS X), and in a build from ant dist.

@gohai

This comment has been minimized.

Show comment
Hide comment
@gohai

gohai Aug 29, 2016

Contributor

Will do!

(BTW: edd9ea3 already stopped copying the fonts into the jre font directories - so this approach better works or it's probably best to revert completely)

Contributor

gohai commented Aug 29, 2016

Will do!

(BTW: edd9ea3 already stopped copying the fonts into the jre font directories - so this approach better works or it's probably best to revert completely)

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Aug 29, 2016

Member

Yup, saw that—just need to make sure that we're not missing anything with the extra logic here. Or do you think we're safe to just incorporate this, since if things are broken, it's gonna be a lot of rollback?

Member

benfry commented Aug 29, 2016

Yup, saw that—just need to make sure that we're not missing anything with the extra logic here. Or do you think we're safe to just incorporate this, since if things are broken, it's gonna be a lot of rollback?

@gohai

This comment has been minimized.

Show comment
Hide comment
@gohai

gohai Aug 29, 2016

Contributor

Either way is fine, but I better test before you release even without it :)

Contributor

gohai commented Aug 29, 2016

Either way is fine, but I better test before you release even without it :)

@gohai

This comment has been minimized.

Show comment
Hide comment
@gohai

gohai Sep 4, 2016

Contributor

@benfry I tested Mac, Windows (10), and (ARM) Linux - ant run and ant dist, with a fresh preferences.txt, while watching the terminal output. Looked all good!

Contributor

gohai commented Sep 4, 2016

@benfry I tested Mac, Windows (10), and (ARM) Linux - ant run and ant dist, with a fresh preferences.txt, while watching the terminal output. Looked all good!

@benfry benfry merged commit 7da482f into processing:master Sep 4, 2016

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Sep 4, 2016

Member

Thanks for looking into all that; much appreciated.

Member

benfry commented Sep 4, 2016

Thanks for looking into all that; much appreciated.

@gohai gohai deleted the gohai:jvm-fonts-all-os branch Feb 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment