GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wanted to at least remove the misleading comment that the last fallback is for Linux only, but ended up removing the other cases too (which are hopefully not needed anymore).
Can't incorporate this until someone tests the change across all platforms: Windows, macOS, Linux, and when running from ant run, from Eclipse (at least on OS X), and in a build from ant dist.
(BTW: edd9ea3 already stopped copying the fonts into the jre font directories - so this approach better works or it's probably best to revert completely)
Yup, saw that—just need to make sure that we're not missing anything with the extra logic here. Or do you think we're safe to just incorporate this, since if things are broken, it's gonna be a lot of rollback?
Either way is fine, but I better test before you release even without it :)
@benfry I tested Mac, Windows (10), and (ARM) Linux - ant run and ant dist, with a fresh preferences.txt, while watching the terminal output. Looked all good!
Thanks for looking into all that; much appreciated.