New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDEX: Add 'Jump to Declaration' to right-click menu (#4668) #4707

Merged
merged 1 commit into from Feb 13, 2017

Conversation

Projects
None yet
2 participants
@rzats
Contributor

rzats commented Oct 19, 2016

Contains

A simple implementation for #4668 - adds a "Jump to Declaration" option to the PDEX context menu with the same functionality as ctrl-clicking on a variable (jumps to the declaration of the variable if it was declared within the sketch; otherwise shows its' usage instead).

image

How to test

In a Processing sketch, right-click on a variable, select "Jump to Declaration" and verify that the declaration is indeed being jumped to 馃槃

Outstanding before merging

  • When a variable not defined within the sketch is ctrl+clicked, the "Show Usage" window is displayed instead. Should the menu option behave in the same way?

@rzats rzats changed the title from Add 'Jump to Declaration' to PDE right-click menu (#4668) to PDEX: Add 'Jump to Declaration' to right-click menu (#4668) Oct 21, 2016

@rzats

This comment has been minimized.

Show comment
Hide comment
@rzats

rzats Feb 13, 2017

Contributor

@JakubValtar: this has been pending for quite a while 馃槂 Can you please review?

Contributor

rzats commented Feb 13, 2017

@JakubValtar: this has been pending for quite a while 馃槂 Can you please review?

@benfry benfry merged commit 2d5097f into processing:master Feb 13, 2017

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Feb 13, 2017

Member

Just not a high priority and I've not had time鈥 Now merged.

Member

benfry commented Feb 13, 2017

Just not a high priority and I've not had time鈥 Now merged.

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Feb 13, 2017

Member

And yes, this menu option should behave the same way.

Member

benfry commented Feb 13, 2017

And yes, this menu option should behave the same way.

@rzats rzats deleted the rzats:feature-4668 branch Feb 14, 2017

@rzats

This comment has been minimized.

Show comment
Hide comment
@rzats

rzats Feb 14, 2017

Contributor

@benfry: thanks and understood :)

Contributor

rzats commented Feb 14, 2017

@benfry: thanks and understood :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment