CM: Fix null versions in the contribution manager (#4696) #4712

Merged
merged 1 commit into from Oct 29, 2016

Conversation

Projects
None yet
2 participants
@rzats
Contributor

rzats commented Oct 23, 2016

Contains

A fix for #4696 that adds some checks to avoid displaying null in the contribution manager. Note that prettyVersion becomes a "null" string when the base version is invalid - this is reflected in the checks.

How to test

Check that PeasyCam, a library that currently has an invalid contribution file, has no null versions displayed in the contribution manager:

image

@benfry benfry merged commit 891590a into processing:master Oct 29, 2016

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Oct 29, 2016

Member

Thanks… I've removed the check for "null" (the String version) since if that's happening, we should fix the source of the bug, not hide it like this. But with that check removed, PeasyCam looks correct so I think we're set.

Member

benfry commented Oct 29, 2016

Thanks… I've removed the check for "null" (the String version) since if that's happening, we should fix the source of the bug, not hide it like this. But with that check removed, PeasyCam looks correct so I think we're set.

benfry added a commit that referenced this pull request Oct 29, 2016

@rzats rzats deleted the rzats:bugfix-4696 branch Oct 29, 2016

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Nov 3, 2016

Member

Found the problem with the "null" entries, so that's now fixed too. Thanks again for your help.

Member

benfry commented Nov 3, 2016

Found the problem with the "null" entries, so that's now fixed too. Thanks again for your help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment