New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract state from TokenMarker #4761

Merged
merged 1 commit into from Dec 4, 2016

Conversation

Projects
None yet
2 participants
@JakubValtar
Contributor

JakubValtar commented Dec 4, 2016

TokenMarker now serves as a holder for keyword list and to provide
marking logic. I extracted the rest into TokenMarkerState. Each tab now
has its own state, preventing bugs by leaking TokenMarker state between
tabs amd Editor instances.

There is no need to recompile any Modes, however TokenMarker should be
redesigned in the next major version and Modes updated accordingly.

For more details read TokenMarkerState header.

Fixes #4522

Extract state from TokenMarker
TokenMarker now serves as a holder for keyword list and to provide
marking logic. I extracted the rest into TokenMarkerState. Each tab now
has its own state, preventing bugs by leaking TokenMarker state between
tabs amd Editor instances.

There is no need to recompile any Modes, however TokenMarker should be
redesigned in the next major version and Modes updated accordingly.

For more details read TokenMarkerState header.

@benfry benfry merged commit f6a8576 into processing:master Dec 4, 2016

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Dec 4, 2016

Member

Thanks; generally it's something where we should rip out the buggy JEditSyntax package and replace it with a better editor component rather than continuing this sort of duct tape… As with most things in processing.app.syntax, TokenMarker isn't our code, and isn't representative of how we'd build such a beast.

Member

benfry commented Dec 4, 2016

Thanks; generally it's something where we should rip out the buggy JEditSyntax package and replace it with a better editor component rather than continuing this sort of duct tape… As with most things in processing.app.syntax, TokenMarker isn't our code, and isn't representative of how we'd build such a beast.

@JakubValtar

This comment has been minimized.

Show comment
Hide comment
@JakubValtar

JakubValtar Dec 4, 2016

Contributor

I agree. We should do this next time we plan to break API (Processing 4?).

Contributor

JakubValtar commented Dec 4, 2016

I agree. We should do this next time we plan to break API (Processing 4?).

@JakubValtar JakubValtar deleted the JakubValtar:fix-token-marker branch Dec 17, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment