New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace keyChar with keyCode to prevent new line error when debugging #4806

Merged
merged 1 commit into from Jan 29, 2017

Conversation

Projects
None yet
2 participants
@joelmoniz
Member

joelmoniz commented Jan 1, 2017

This PR replaces the keyChar check used to trigger auto-indent with a keyCode check, and fixes #4804. Ctrl+J happens to be an escape sequence representing new line (and their keyChar values are therefore both 10/\n), so Ctrl+J and Ctrl+Shift+J created a new line to appear when stepping. The keyCode for the Enter Key, however, is different, and hitting the Enter Key would be when the auto-format is triggered.

@benfry benfry merged commit 40fe46d into processing:master Jan 29, 2017

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Jan 29, 2017

Member

Ah! Nice simple fix. Thank you.

Member

benfry commented Jan 29, 2017

Ah! Nice simple fix. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment