Add missing equals() and hashCode() to Contribution #4843

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
2 participants
@JakubValtar
Contributor

JakubValtar commented Jan 21, 2017

Mind your contracts.

Fixes #4840

Probably #4822 too, check with @jdf afterwards.

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Jan 29, 2017

Member

Added manually due to merge conflict.

Member

benfry commented Jan 29, 2017

Added manually due to merge conflict.

@benfry benfry closed this Jan 29, 2017

@JakubValtar

This comment has been minimized.

Show comment
Hide comment
@JakubValtar

JakubValtar Jan 29, 2017

Contributor

@benfry You missed the changes from other two files. Removing equals() from ModeContribution is essential. The comment not so much.

Contributor

JakubValtar commented Jan 29, 2017

@benfry You missed the changes from other two files. Removing equals() from ModeContribution is essential. The comment not so much.

benfry added a commit that referenced this pull request Jan 29, 2017

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Jan 29, 2017

Member

Oops, glad you caught that—the first diff fit perfectly on my screen so I didn't see that there were more updates.

Member

benfry commented Jan 29, 2017

Oops, glad you caught that—the first diff fit perfectly on my screen so I didn't see that there were more updates.

@JakubValtar JakubValtar deleted the JakubValtar:fix-cm-listing branch Jan 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment