New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grab bag of Contribution Manager fixes I accumulated while fixing other stuff #4844

Merged
merged 6 commits into from Jan 29, 2017

Conversation

Projects
None yet
2 participants
@JakubValtar
Contributor

JakubValtar commented Jan 21, 2017

  • Fire table change notifincations only after all changes happened
  • In listeners, ignore contributions which are of different kind than current tab
  • Remove redundant invokeLater() which spammed EDT with hundreds of Runnables
  • Remove some manual sychronization since the code runs on EDT
  • Remove two conditions which are always true
  • Fix Update tab which broke in the process - contributions now stay on update screen with spinning wheel until installation completes

JakubValtar added some commits Jan 21, 2017

Add filter conditions so contribs from other tabs are ignored
Wrapped both method bodies with one if condition each. Blame the diff.
Remove gratuitous invokeLater()
Again, just unwrapped bodies from invokeLater, because they run on EDT
already. Some were called in loops and spammed EDT with hundreds of
Runnables.
Get rid of unnecessary manual synchronization
Remove manual synchronization on visibleContributions and
panelByContribution. Both are accessed only from EDT.
Fix broken Update tab
Contribution stays there with spinning wheel until the installation
completes

@benfry benfry merged commit e6eb9bd into processing:master Jan 29, 2017

@JakubValtar JakubValtar deleted the JakubValtar:cm-extra branch Jan 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment