New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to sketch launching and stopping #4848

Merged
merged 4 commits into from Jan 29, 2017

Conversation

Projects
None yet
2 participants
@JakubValtar
Contributor

JakubValtar commented Jan 23, 2017

  • Put stuff on correct threads and added proper synchronization
  • Run button stays active after restarting sketch
  • Run and Stop buttons now work reliably
  • Restarting sketch with Run button while debugging is fixed

JakubValtar added some commits Jan 21, 2017

Make run button behave
When clicking run button while a sketch is running, it will be activated
again when the sketch is restarted. Previously it got deactivated by the
old sketch runner, because it was quitting after the new sketch runner
started.
Add proper synchronization for sketch launching and closing
Pressing Run button twice launched two sketch windows, but only one of
them could be closed by Stop button. Pressing Stop had effect only after
sketch VM was launched.

Both of these issues are now fixed and buttons can handle a
frustration-relieving session of aggressive clicking, leaving one sketch
window if Run was the last button pressed or no window if Stop was the
last button pressed.
Fix restarting sketch in Debug mode when Run is pressed
Disconnect event of the old VM would arrive after the new VM was
created, closing it instantly and leaving user without a running sketch.

@benfry benfry merged commit 334098d into processing:master Jan 29, 2017

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Jan 29, 2017

Member

Awesome, thank you.

Member

benfry commented Jan 29, 2017

Awesome, thank you.

@JakubValtar JakubValtar deleted the JakubValtar:fix-run-threads branch Jan 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment