New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more Raspberry Pi related fixes to JOGL #4911

Merged
merged 1 commit into from Apr 20, 2017

Conversation

Projects
None yet
3 participants
@gohai
Contributor

gohai commented Feb 16, 2017

This hopefully addresses #4499 and works around the long-standing dual driver stack issue on Raspbian.

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Feb 18, 2017

Member

Is that a separate JOGL build you created?

Member

benfry commented Feb 18, 2017

Is that a separate JOGL build you created?

@gohai

This comment has been minimized.

Show comment
Hide comment
@gohai

gohai Feb 18, 2017

Contributor

@benfry Yes. JOGL 2.3.2 plus the following patches on top. Hope to at least fix one more bug, before we grow the repo size because of it. I'm in touch with @xranby about incorporating those in some form or another into upstream JOGL eventually also.

Contributor

gohai commented Feb 18, 2017

@benfry Yes. JOGL 2.3.2 plus the following patches on top. Hope to at least fix one more bug, before we grow the repo size because of it. I'm in touch with @xranby about incorporating those in some form or another into upstream JOGL eventually also.

@gohai gohai changed the title from [DONT PULL YET] Add more Raspberry Pi related fixes to JOGL to Add more Raspberry Pi related fixes to JOGL Mar 5, 2017

@gohai

This comment has been minimized.

Show comment
Hide comment
@gohai

gohai Mar 5, 2017

Contributor

@benfry I added one more fix, so from my perspective that'd be ready to go in. What this is improving is listed in the commit description.

Contributor

gohai commented Mar 5, 2017

@benfry I added one more fix, so from my perspective that'd be ready to go in. What this is improving is listed in the commit description.

Add more Raspberry Pi specific fixes to JOGL
This adds the following fixes on top of 434455a (patches at https://github.com/gohai/jogl):
* Fix GL overlay offset when overscan is enabled
* Fix the value of mouseButton (#4499)
* Change libGLESv2 search order to work around longstanding issue in Raspbian
@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Mar 11, 2017

Member

And no activity on the JOGL front, huh? So unlikely that this will be coming in an official build anytim soon?

@codeanticode Any other JOGL tweaks we need before incorporating a new binary like this?

Member

benfry commented Mar 11, 2017

And no activity on the JOGL front, huh? So unlikely that this will be coming in an official build anytim soon?

@codeanticode Any other JOGL tweaks we need before incorporating a new binary like this?

@gohai

This comment has been minimized.

Show comment
Hide comment
@gohai

gohai Mar 11, 2017

Contributor

I wouldn't hold my breath for an upcoming JOGL release ... Xerxes is in the know about those patches though

Contributor

gohai commented Mar 11, 2017

I wouldn't hold my breath for an upcoming JOGL release ... Xerxes is in the know about those patches though

@codeanticode

This comment has been minimized.

Show comment
Hide comment
@codeanticode

codeanticode Mar 11, 2017

Member

I don't have any JOGL tweaks at this time. I will look at some GL issues as soon as I can (for example #4807), but I don't those require any fixes in JOGL

I've been following reports about problems connecting to HDMI/Hires displays, e.g.: #4728 #4954, and my concern is that those might be caused by some upstream problem in JOGL...

Member

codeanticode commented Mar 11, 2017

I don't have any JOGL tweaks at this time. I will look at some GL issues as soon as I can (for example #4807), but I don't those require any fixes in JOGL

I've been following reports about problems connecting to HDMI/Hires displays, e.g.: #4728 #4954, and my concern is that those might be caused by some upstream problem in JOGL...

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Mar 11, 2017

Member

#4728 and #4954 probably need some attention, since two similar reports likely means several people having issues. Though that code would be outside the jogl-all.jar that's being updated here, right? So maybe we go ahead with this stuff.

Member

benfry commented Mar 11, 2017

#4728 and #4954 probably need some attention, since two similar reports likely means several people having issues. Though that code would be outside the jogl-all.jar that's being updated here, right? So maybe we go ahead with this stuff.

@codeanticode

This comment has been minimized.

Show comment
Hide comment
@codeanticode

codeanticode Mar 11, 2017

Member

I'm pretty confident that the issues with HDMI/hi-res output are entirely separate from the RPi fixes from Gottfried.

Member

codeanticode commented Mar 11, 2017

I'm pretty confident that the issues with HDMI/hi-res output are entirely separate from the RPi fixes from Gottfried.

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Mar 12, 2017

Member

I'm sure of that. The point was that this is an update to jogl-all.jar (the non-native part of JOGL), and those other issues all live inside the native code for macOS, right? Meaning that if we make this update, we're unlikely to need another jogl-all.jar update soon if other fixes are made for that other stuff.

The issue is that once we add binary blobs, they're in the repo forever. So if it's likely that we need to update jogl-all.jar in a couple weeks for the high-res issues, let's wait.

Member

benfry commented Mar 12, 2017

I'm sure of that. The point was that this is an update to jogl-all.jar (the non-native part of JOGL), and those other issues all live inside the native code for macOS, right? Meaning that if we make this update, we're unlikely to need another jogl-all.jar update soon if other fixes are made for that other stuff.

The issue is that once we add binary blobs, they're in the repo forever. So if it's likely that we need to update jogl-all.jar in a couple weeks for the high-res issues, let's wait.

@codeanticode

This comment has been minimized.

Show comment
Hide comment
@codeanticode

codeanticode Mar 12, 2017

Member

Ok, got it. Let me look at the hi-res issues first, because I'm not certain whether those are due to some problem with the native libs, or in the platform-specific Java code.

Member

codeanticode commented Mar 12, 2017

Ok, got it. Let me look at the hi-res issues first, because I'm not certain whether those are due to some problem with the native libs, or in the platform-specific Java code.

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Mar 13, 2017

Member

Great; thanks.

Member

benfry commented Mar 13, 2017

Great; thanks.

@codeanticode

This comment has been minimized.

Show comment
Hide comment
@codeanticode

codeanticode Mar 27, 2017

Member

I would go ahead with the merge as, regarding the issues I mentioned before, one appears to be caused by a hardware failure and the other can be solved with a resolution-setting tool.

Member

codeanticode commented Mar 27, 2017

I would go ahead with the merge as, regarding the issues I mentioned before, one appears to be caused by a hardware failure and the other can be solved with a resolution-setting tool.

@benfry benfry merged commit 3ee7d7c into processing:master Apr 20, 2017

@gohai gohai deleted the gohai:jogl-fixes branch Apr 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment