New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report more error conditions in validateFramebuffer #4920

Merged
merged 2 commits into from Feb 19, 2017

Conversation

Projects
None yet
3 participants
@gohai
Contributor

gohai commented Feb 18, 2017

I don't know what any of this means, but hope the gesture will be apprechiated :)

@gohai gohai requested review from codeanticode and JakubValtar Feb 18, 2017

@JakubValtar

This comment has been minimized.

Show comment
Hide comment
@JakubValtar

JakubValtar Feb 18, 2017

Contributor

@gohai Good idea! Since we are messing with this, can you please look at glCheckFramebufferStatus docs and add all the codes which are documented there? Please don't delete the ones which are not on the page, I think they might be encountered when running older GL versions. If the constants are not in com.jogamp.opengl.GL, they will be in com.jogamp.opengl.GL4.

Contributor

JakubValtar commented Feb 18, 2017

@gohai Good idea! Since we are messing with this, can you please look at glCheckFramebufferStatus docs and add all the codes which are documented there? Please don't delete the ones which are not on the page, I think they might be encountered when running older GL versions. If the constants are not in com.jogamp.opengl.GL, they will be in com.jogamp.opengl.GL4.

@gohai

This comment has been minimized.

Show comment
Hide comment
@gohai

gohai Feb 18, 2017

Contributor

@JakubValtar Should be done. I picked com.jogamp.opengl.GL3 since this was also was JOGL was using for those constants.

Contributor

gohai commented Feb 18, 2017

@JakubValtar Should be done. I picked com.jogamp.opengl.GL3 since this was also was JOGL was using for those constants.

@codeanticode

This comment has been minimized.

Show comment
Hide comment
@codeanticode

codeanticode Feb 18, 2017

Member

Yes, looks good.

Member

codeanticode commented Feb 18, 2017

Yes, looks good.

@JakubValtar

This comment has been minimized.

Show comment
Hide comment
@JakubValtar

JakubValtar Feb 18, 2017

Contributor

Nice work, please merge

Contributor

JakubValtar commented Feb 18, 2017

Nice work, please merge

@gohai gohai merged commit 4db750c into processing:master Feb 19, 2017

@gohai gohai deleted the gohai:pgl-validateframebuffer branch Feb 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment