New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry with multisampling disabled if creating a framebuffer fails because of INCOMPLETE_MULTISAMPLE #4921

Merged
merged 1 commit into from Feb 19, 2017

Conversation

Projects
None yet
2 participants
@gohai
Contributor

gohai commented Feb 18, 2017

No idea if tearing down the FBO half-way and setting it back up again is recommended practice, but this does make the Primitives3D example work for me with the Mesa VC4 driver (see #4919).

@gohai gohai requested review from codeanticode and JakubValtar Feb 18, 2017

@gohai

This comment has been minimized.

Show comment
Hide comment
@gohai

gohai Feb 18, 2017

Contributor

This depends on #4920 for the new constant.

Contributor

gohai commented Feb 18, 2017

This depends on #4920 for the new constant.

@codeanticode

This comment has been minimized.

Show comment
Hide comment
@codeanticode

codeanticode Feb 18, 2017

Member

I think is a good fallback, go ahead and merge.

Member

codeanticode commented Feb 18, 2017

I think is a good fallback, go ahead and merge.

@gohai gohai merged commit c8fa07f into processing:master Feb 19, 2017

@gohai gohai deleted the gohai:pgl-multisampling-fallback branch Feb 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment