Revert "Fix 3D on contemporary versions of Linux (fixes #5308)" #5652
Conversation
…)" This reverts commit 5729c6b. While this appears to have fixed GL for the AMD graphics users in processing#5308 it seems to have broke it for folks in processing#5476. It seems JOGL is abandoned these days, and I don't have the capacity to figure this out on my own. This patch reverts the "fix", so that it will continue to work on the systems that it traditionally worked on (and probably not on newer configuration not properly handled by JOGL).
|
Does this patch actually revert or is it just checking in the old version once again? |
|
It's a |
|
Cool, thanks. |
|
Can we close #5476 as fixed by this? |
|
Yes, I just did |
|
Why not use something like LWJGL instead of JOGL? Or is that overkill? |
|
@neilcsmith-net Yes, feel free to reopen. |
|
@laaas that's probably what has to happen, but it's a big step. And AFAIK doesn't support ARM yet unless it's been added very recently. Incidentally, @gohai I think the right fix for this is to revert the reversion, and look at what's going on with profiles that Processing / JOGL is trying to use backwards compatibility on a context that doesn't support it. This is the same as macOS, right? But it works there. See https://discourse.processing.org/t/solved-p2d-p3d-sketches-wont-start-on-fresh-ubuntu-18-04-installation/3568/33?u=neilcsmith Setting |
|
@neilcsmith-net Feel free to look into it and send patches - I don't have an an AMD graphic card to test, and also not the time to get to the bottom of it. LWJGL does run on ARM Linux. |
|
@gohai I can try and look further, but can you revert this reversion of JOGL? If the system property works for some AMD cards then it could be passed into Processing, or could look at a patch to try that on failure, but without the patch other (most?) AMD graphics users will be screwed! 😄 On LWJGL and ARM I'd just been going on this still being open so not fully supported yet? LWJGL/lwjgl3#206 |
|
@neilcsmith-net We tried the proposed patch that fixed graphics for some AMD users, but this ended up breaking it for others. I don't have the resources to work on a better fix, hence the revert to where things were before. Folks run Minecraft on the Pi using LWJGL, so it appears to work. |
|
@gohai I understand the history, but with the system property above it hopefully works for everyone. If you revert the patch it cannot work for some, probably the majority of affected users. I'm happy to keep investigating but to do so I think the patched JOGL needs to go back in. From there we can hopefully work out why the profile is wrongly being thought to be backwards compatible. I've seen that also once recently on an nVidia card with Mesa. I suspect it's actually something in the Processing code triggering it, or at least something that can be worked around there. |
|
Please send a patch that reverts the revert, and fixes it for everyone else at the same time, @neilcsmith-net. |
|
@gohai yes, I'll see if that's feasible. But if it isn't, it's still far easier for a user to set a system property in a config file than rip apart the install to insert a patched JOGL file! |
This reverts commit 5729c6b.
While this appears to have fixed GL for the AMD graphics users in #5308 it seems to have broke it for folks in #5476. It seems JOGL is abandoned these days, and I don't have the capacity to figure this out on my own. This patch reverts the "fix", so that it will continue to work on the systems that it traditionally worked on (and probably not on newer configuration not properly handled by JOGL).