Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong FORM_TYPE for IBR form with CAPTCHA #3045

Closed
linkmauve opened this issue Sep 29, 2019 · 2 comments

Comments

@linkmauve
Copy link

commented Sep 29, 2019

Environment

  • ejabberd version: unknown
  • Erlang version: unknown
  • OS: unknown
  • Installed from: unknown

Configuration (only if needed): unknown

Errors from error.log/crash.log

No errors

Bug description

When doing in-band registration with some Ejabberd server with a CAPTCHA, such as creep.im or patchcord.be, the FORM_TYPE is urn:xmpp:captcha instead of jabber:iq:registration like it should be as defined by XEP-0077 and extended by XEP-0158.

@linkmauve linkmauve added the Kind:Bug label Sep 29, 2019
@zinid zinid added this to the ejabberd 19.11 milestone Oct 1, 2019
@badlop

This comment has been minimized.

Copy link
Member

commented Oct 3, 2019

Maybe I'm missing something... What you consider a bug is in fact described in example 11 from https://xmpp.org/extensions/xep-0158.html#register , and is similarly provided by ejabberd 19.09:

<iq xmlns="jabber:client"
    to="localhost"
    type="get"
    id="4620ac0b-09a7-4c02-92bf-573652f5cdb5">
  <query xmlns="jabber:iq:register" />
</iq>

<iq xml:lang='ca'
    from='localhost'
    type='result'
    id='4620ac0b-09a7-4c02-92bf-573652f5cdb5'>
  <query xmlns='jabber:iq:register'>
    <x type='form'
       xmlns='jabber:x:data'>
      <instructions>Tria nom d'usuari i contrasenya per a
      registrar-te en aquest servidor</instructions>
      <field var='FORM_TYPE'
             type='hidden'>
        <value>urn:xmpp:captcha</value>
      </field>
      <field var='username'
             type='text-single'
             label='Usuari'>
        <required />
      </field>
      ...
    </x>
  </query>
</iq>
@zinid zinid added Note:Needs more info and removed Kind:Bug labels Oct 4, 2019
@zinid

This comment has been minimized.

Copy link
Member

commented Oct 9, 2019

I close the ticket because ejabberd respects namespace requirements from XEP-0158. If there are any discrepancies in the XEPs, this should be addressed at the XSF.

@zinid zinid closed this Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.