Reduce size of XML stream state #28
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes size of hibernated ejabberd_receiver a lot smaller (from ~290 words down to ~40).
|
Thank you for the patch. We will have a look :) |
ghost
assigned 
|
Any feedback on this? I've been running it on a 16 node ejabberd cluster for quite a while without any problems:) |
|
Yes, we will integrate this patch at some point but we are doing lot of change in ejabberd code structure, so it will come after :) |
|
Seems like this pull request was already merged. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes size of hibernated ejabberd_receiver a lot smaller (from ~290 words down to ~40).
Obviously, this will make any noticeable benefit only in some specific cases (like having lots of users with empty roster as usually ejabberd_c2s will eat a lot more memory than ejabberd_receiver).