New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Go Modules #1

merged 1 commit into from Jan 17, 2019


None yet
2 participants
Copy link

SamWhited commented Jan 16, 2019

Like processone/mpg123#1, this patch adds basic support for Go Modules, the new packaging standard that will be on by default Go 1.12. Experimental support is in Go 1.11 and the new module paths are supported in Go 1.9.7+ and Go 1.10.3+ in a read-only manner for backwards compatibility with all supported versions of Go.

Because this library is still below version 2, and has few external dependencies, the go.mod file is fairly simple. If you accept this PR, the only other thing to do would be to start using semver compatible tags and tag a release of this library that others can pin to (for example v0.0.1 or v1.0.0).

The go.sum file in this patch is used to verify that when users download a particular version of your dependencies, they are seeing the same thing you saw (eg. in case of a Git hash collision, or a malicious package author that tries to change things after the fact).

Thank you for your consideration, I look forward to being able to pin to a specific version of these libraries.

@SamWhited SamWhited referenced this pull request Jan 16, 2019


Support Go Modules #14

@mremond mremond self-assigned this Jan 17, 2019

@mremond mremond added the enhancement label Jan 17, 2019

@mremond mremond merged commit 095f949 into processone:master Jan 17, 2019

@SamWhited SamWhited deleted the SamWhited:support_modules branch Jan 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment