New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix problem with MQTT SUBACK packages #104

Merged
merged 1 commit into from Sep 9, 2014

Conversation

Projects
None yet
2 participants
@minleychris
Contributor

minleychris commented Sep 3, 2014

Seems like the packets were falling between the cracks.

nniclausse added a commit that referenced this pull request Sep 9, 2014

Merge pull request #104 from minleychris/fix_mqtt_ssl
Fix problem with MQTT SUBACK packages

@nniclausse nniclausse merged commit 27cf6f5 into processone:master Sep 9, 2014

@nniclausse

This comment has been minimized.

Show comment
Hide comment
@nniclausse

nniclausse Sep 9, 2014

Contributor

i was too fast to merge the PR. Your commit make the tests fails:

ts_test_mqtt: decode_disconnect_test...failed
in function ts_test_mqtt:decode_disconnect_test/0 (src/test/ts_test_mqtt.erl, line 70)
**error:{badmatch,more}

ts_test_mqtt: decode_ping_test...failed
in function ts_test_mqtt:decode_ping_test/0 (src/test/ts_test_mqtt.erl, line 128)
**error:{badmatch,more}

ts_test_mqtt: decode_pong_test...failed
in function ts_test_mqtt:decode_pong_test/0 (src/test/ts_test_mqtt.erl, line 139)
**error:{badmatch,more}

what was the problem with SUBACK ?

Contributor

nniclausse commented Sep 9, 2014

i was too fast to merge the PR. Your commit make the tests fails:

ts_test_mqtt: decode_disconnect_test...failed
in function ts_test_mqtt:decode_disconnect_test/0 (src/test/ts_test_mqtt.erl, line 70)
**error:{badmatch,more}

ts_test_mqtt: decode_ping_test...failed
in function ts_test_mqtt:decode_ping_test/0 (src/test/ts_test_mqtt.erl, line 128)
**error:{badmatch,more}

ts_test_mqtt: decode_pong_test...failed
in function ts_test_mqtt:decode_pong_test/0 (src/test/ts_test_mqtt.erl, line 139)
**error:{badmatch,more}

what was the problem with SUBACK ?

@minleychris

This comment has been minimized.

Show comment
Hide comment
@minleychris

minleychris Sep 9, 2014

Contributor

The packet was on some sort of boundary, so TLS subacks would fail to find the right pattern match. We are using the TLS mqtt code heavily here, so I'm confident these are problems with the tests. I'll take a look at them (my erlang isn't great, though)

Contributor

minleychris commented Sep 9, 2014

The packet was on some sort of boundary, so TLS subacks would fail to find the right pattern match. We are using the TLS mqtt code heavily here, so I'm confident these are problems with the tests. I'll take a look at them (my erlang isn't great, though)

@minleychris

This comment has been minimized.

Show comment
Hide comment
@minleychris

minleychris Sep 9, 2014

Contributor

Just looking into this more it's the difference between only one packet being received and two or more, I'll get back to you with a fix soon.

Contributor

minleychris commented Sep 9, 2014

Just looking into this more it's the difference between only one packet being received and two or more, I'll get back to you with a fix soon.

@nniclausse

This comment has been minimized.

Show comment
Hide comment
@nniclausse

nniclausse Sep 9, 2014

Contributor

OK thanks, it's fixed in PR #105

Contributor

nniclausse commented Sep 9, 2014

OK thanks, it's fixed in PR #105

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment