tsung fails in ts_dynvars:merge when arguments are [<<>>, Dynvars]#258
Merged
Conversation
Collaborator
|
I'm not sure I can follow this completly. When exactly can this happen? And why is it okay for |
Contributor
Author
|
Hi Sebastian I run fixed version on my branch , i exercise a proprietary protocol plugin with Tsung. |
Collaborator
|
I guess this is good to go. What do you think, @nniclausse? |
Collaborator
|
@izinin I'd like to get this merged. Could you please change the target branch to |
tisba
approved these changes
May 30, 2018
Collaborator
|
Never mind. Just realised, that I can change the base branch myself :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
ts_dynvars:merge function implementation is unsafe because it does not provide alternative for error case.
For example, in case if 'dynvars' enabled and there is no variable substitutions detected it crashes because it fails to merge empty buffer with existed Dynvars. This happens when i mix variable substitution on and off in different requests in one transaction
Regards,
Igor