Skip to content

Travis: Test against Erlang 21#323

Merged
tisba merged 3 commits into
developfrom
test-with-erlang-21
Jul 23, 2018
Merged

Travis: Test against Erlang 21#323
tisba merged 3 commits into
developfrom
test-with-erlang-21

Conversation

@tisba

@tisba tisba commented Jul 22, 2018

Copy link
Copy Markdown
Collaborator

This PR instructs Travis CI also to build against Erlang/OTP 21.

So far I've not done any further testing, but only a small change was required to get it to run tests without issues. The same compiler warnings as already reported in #312 popped up, but beside this, it seems to be fine.

PS: I changed the versions to strings in .travis.yml. This way it is unmistakable as a version, and not as a number (e.g. 1.0.0 will be interpreted as 1.0). This was not an issue, I just wanted to make it more robust.

@tisba tisba added this to the 1.8.0 milestone Jul 22, 2018
@tisba
tisba requested a review from nniclausse July 22, 2018 12:01
@tisba

tisba commented Jul 22, 2018

Copy link
Copy Markdown
Collaborator Author

The adjusted test in ts_test_utils.erl now fails with other Erlang versions. I don't yet understand why this breaks though :-/

@tisba

tisba commented Jul 22, 2018

Copy link
Copy Markdown
Collaborator Author

The issue has been reported as https://bugs.erlang.org/browse/ERL-633 but as correctly noted there, one should not rely on the exact return value of io_lib:format but use lists:flatten/1 instead. I'll adjust the test accordingly.

@tisba tisba removed this from the 1.8.0 milestone Jul 22, 2018
@tisba
tisba merged commit 167b944 into develop Jul 23, 2018
@tisba
tisba deleted the test-with-erlang-21 branch July 23, 2018 17:47
@nniclausse nniclausse added this to the 1.8.0 milestone Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants