mqtt subscribe packet MUST set qos to 1 for the fixed header#327
Merged
tisba merged 2 commits intoprocessone:developfrom Aug 22, 2018
Merged
mqtt subscribe packet MUST set qos to 1 for the fixed header#327tisba merged 2 commits intoprocessone:developfrom
tisba merged 2 commits intoprocessone:developfrom
Conversation
Collaborator
Contributor
Author
|
Hey @tisba thanks for pointing out the other issue. Yes, it's an exact duplicate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I discovered this while testing with VerneMQ. According to the MQTT spec, bits 3,2,1 and 0 of the fixed header of the SUBSCRIBE Control Packet are reserved and MUST be set to 0,0,1 and 0 respectively. Tsung sets these to 0,0,0,0 which causes VerneMQ to drop the connection.
https://docs.solace.com/MQTT-311-Prtl-Conformance-Spec/MQTT%20Control%20Packets.htm#_Toc430864927